Bug 101775 - [Qt] MiniBrowser should not strongly depend on QtTestSupport.
Summary: [Qt] MiniBrowser should not strongly depend on QtTestSupport.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zeno Albisser
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 09:54 PST by Zeno Albisser
Modified: 2012-11-12 03:09 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.81 KB, patch)
2012-11-09 09:59 PST, Zeno Albisser
no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2012-11-09 10:56 PST, Zeno Albisser
vestbo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Albisser 2012-11-09 09:54:34 PST
[Qt] MiniBrowser should not strongly depend on QtTestSupport.
Comment 1 Zeno Albisser 2012-11-09 09:59:47 PST
Created attachment 173331 [details]
Patch
Comment 2 Early Warning System Bot 2012-11-09 10:16:55 PST
Comment on attachment 173331 [details]
Patch

Attachment 173331 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14792125
Comment 3 Early Warning System Bot 2012-11-09 10:19:00 PST
Comment on attachment 173331 [details]
Patch

Attachment 173331 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14794032
Comment 4 Andras Becsi 2012-11-09 10:36:49 PST
Comment on attachment 173331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173331&action=review

> Source/WebCore/Target.pri:4079
> +if(build?(qttestsupport)) {

This should probably be have?(qttestsupport), which should fix the build.
Comment 5 Zeno Albisser 2012-11-09 10:42:44 PST
Comment on attachment 173331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173331&action=review

>> Source/WebCore/Target.pri:4079
>> +if(build?(qttestsupport)) {
> 
> This should probably be have?(qttestsupport), which should fix the build.

No, that is intentional. As it is translated from build to have in features.prf.

> Source/WebCore/platform/qt/QtTestSupport.h:27
> +#if HAVE(QTTESTSUPPORT)

But these one here is evil. I should have known better. :-)
Comment 6 Zeno Albisser 2012-11-09 10:56:51 PST
Created attachment 173336 [details]
Patch
Comment 7 Tor Arne Vestbø 2012-11-11 07:11:34 PST
Comment on attachment 173336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173336&action=review

> Source/WebCore/Target.pri:4079
> +if(build?(qttestsupport)) {

you can simplify this to just build?(qttestsupport) {}
Comment 8 Zeno Albisser 2012-11-12 03:09:01 PST
Committed r134200: <http://trac.webkit.org/changeset/134200>