RESOLVED FIXED 101761
[EFL] Turn on error on warnings for "sign-compare" 
https://bugs.webkit.org/show_bug.cgi?id=101761
Summary [EFL] Turn on error on warnings for "sign-compare"
Laszlo Gombos
Reported 2012-11-09 07:51:12 PST
Remove "-Wno-error=sign-compare" from Source/cmake/WebKitHelpers.cmake and fix the remaining build errors - if any.
Attachments
Patch (1.32 KB, patch)
2012-11-13 15:01 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2012-11-13 22:39 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2012-11-14 01:07 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-11-09 08:09:27 PST
WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:110:130: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] WebCore/platform/posix/SharedBufferPOSIX.cpp:55:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
KyungTae Kim
Comment 2 2012-11-11 22:46:23 PST
There's an argue related with the below bug on 101458 now. WebCore/platform/posix/SharedBufferPOSIX.cpp:55:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
KyungTae Kim
Comment 3 2012-11-13 15:01:53 PST
Created attachment 173998 [details] Patch
EFL EWS Bot
Comment 4 2012-11-13 16:19:08 PST
Comment on attachment 173998 [details] Patch Attachment 173998 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14826351
KyungTae Kim
Comment 5 2012-11-13 22:39:16 PST
Created attachment 174079 [details] Patch
WebKit Review Bot
Comment 6 2012-11-14 00:38:23 PST
Comment on attachment 174079 [details] Patch Rejecting attachment 174079 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: (content): Merge conflict in LayoutTests/ChangeLog Failed to merge in the changes. Patch failed at 0001 After r134205 was rolled out in http://trac.webkit.org/changeset/134425, When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14831256
KyungTae Kim
Comment 7 2012-11-14 01:07:44 PST
Created attachment 174101 [details] Patch
WebKit Review Bot
Comment 8 2012-11-14 01:58:24 PST
Comment on attachment 174101 [details] Patch Clearing flags on attachment: 174101 Committed r134578: <http://trac.webkit.org/changeset/134578>
WebKit Review Bot
Comment 9 2012-11-14 01:58:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.