Bug 101751 - MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
Summary: MediaStream API: Schedule the RTCDataChannel events to be triggered at idle s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-11-09 06:04 PST by Tommy Widenflycht
Modified: 2012-11-12 04:26 PST (History)
9 users (show)

See Also:

Attachments
Patch (13.58 KB, patch)
2012-11-09 06:10 PST, Tommy Widenflycht 		abarth: review+
Details | Formatted Diff | Diff
Patch for landing (13.65 KB, patch)
2012-11-12 02:46 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-11-09 06:04:15 PST 
MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
Comment 1 Tommy Widenflycht 2012-11-09 06:10:36 PST 
Created attachment 173290 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-09 06:13:01 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Adam Barth 2012-11-09 11:20:43 PST 
Comment on attachment 173290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173290&action=review

> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:288
> +    events.clear();

This line shouldn't be needed.  The vector will get cleared naturally as the stack unwinds.
Comment 4 Tommy Widenflycht 2012-11-12 02:46:46 PST 
Created attachment 173597 [details]
Patch for landing
Comment 5 Tommy Widenflycht 2012-11-12 02:47:21 PST 
Comment on attachment 173290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173290&action=review

>> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:288
>> +    events.clear();
> 
> This line shouldn't be needed.  The vector will get cleared naturally as the stack unwinds.

Removed.
Comment 6 WebKit Review Bot 2012-11-12 04:25:23 PST 
Comment on attachment 173597 [details]
Patch for landing

Clearing flags on attachment: 173597

Committed r134207: <http://trac.webkit.org/changeset/134207>