RESOLVED FIXED Bug 101751
MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
https://bugs.webkit.org/show_bug.cgi?id=101751
Summary MediaStream API: Schedule the RTCDataChannel events to be triggered at idle s...
Tommy Widenflycht
Reported 2012-11-09 06:04:15 PST
MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state
Attachments
Patch (13.58 KB, patch)
2012-11-09 06:10 PST, Tommy Widenflycht
abarth: review+
Patch for landing (13.65 KB, patch)
2012-11-12 02:46 PST, Tommy Widenflycht
no flags
Tommy Widenflycht
Comment 1 2012-11-09 06:10:36 PST
WebKit Review Bot
Comment 2 2012-11-09 06:13:01 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-11-09 11:20:43 PST
Comment on attachment 173290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173290&action=review > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:288 > + events.clear(); This line shouldn't be needed. The vector will get cleared naturally as the stack unwinds.
Tommy Widenflycht
Comment 4 2012-11-12 02:46:46 PST
Created attachment 173597 [details] Patch for landing
Tommy Widenflycht
Comment 5 2012-11-12 02:47:21 PST
Comment on attachment 173290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173290&action=review >> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:288 >> + events.clear(); > > This line shouldn't be needed. The vector will get cleared naturally as the stack unwinds. Removed.
WebKit Review Bot
Comment 6 2012-11-12 04:25:23 PST
Comment on attachment 173597 [details] Patch for landing Clearing flags on attachment: 173597 Committed r134207: <http://trac.webkit.org/changeset/134207>
Note You need to log in before you can comment on or make changes to this bug.