Bug 101733 - MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
Summary: MediaStream API: Make sure that MediaConstraints only has optional and mandat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459
  Show dependency tree / graph
 
Reported: 2012-11-09 02:33 PST by Tommy Widenflycht
Modified: 2012-11-12 08:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2012-11-09 02:41 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (5.20 KB, patch)
2012-11-12 06:46 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-11-09 02:33:59 PST 
MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level
Comment 1 Tommy Widenflycht 2012-11-09 02:41:32 PST 
Created attachment 173249 [details]
Patch
Comment 2 jochen 2012-11-12 06:30:05 PST 
Comment on attachment 173249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173249&action=review

> Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp:70
> +    Vector<String>::iterator it = names.begin();

why don't you put the definition of "it" inside the for ()?
Comment 3 Tommy Widenflycht 2012-11-12 06:38:31 PST 
Comment on attachment 173249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173249&action=review

>> Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp:70
>> +    Vector<String>::iterator it = names.begin();
> 
> why don't you put the definition of "it" inside the for ()?

It makes it more readable imho, I guess you prefer it all in one line? Will fix.
Comment 4 Tommy Widenflycht 2012-11-12 06:46:54 PST 
Created attachment 173640 [details]
Patch
Comment 5 jochen 2012-11-12 06:50:59 PST 
Comment on attachment 173640 [details]
Patch

Looks good, thanks
Comment 6 WebKit Review Bot 2012-11-12 08:35:18 PST 
Comment on attachment 173640 [details]
Patch

Clearing flags on attachment: 173640

Committed r134245: <http://trac.webkit.org/changeset/134245>
Comment 7 WebKit Review Bot 2012-11-12 08:35:22 PST 
All reviewed patches have been landed.  Closing bug.