Bug 101729 - Web Inspector: NMI add instrumentation for WebAudo related stuff. It uses about 16Mb for shared data on pages with webaudio. As example Angry Birds app.
Summary: Web Inspector: NMI add instrumentation for WebAudo related stuff. It uses abo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 01:52 PST by Ilya Tikhonovsky
Modified: 2012-11-18 15:35 PST (History)
19 users (show)

See Also:

Attachments
Patch (30.38 KB, patch)
2012-11-09 05:02 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
for qt bot (30.74 KB, patch)
2012-11-09 05:17 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
with fix for mac and win bots. (30.42 KB, patch)
2012-11-09 06:04 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
with fix for mac, gtk and win bots. (29.38 KB, patch)
2012-11-10 04:14 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
with additional instrumentation for fft arrays. total ~36mb (31.49 KB, patch)
2012-11-11 23:33 PST, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-11-09 01:52:32 PST 
EOM
Comment 1 Ilya Tikhonovsky 2012-11-09 05:02:55 PST 
Created attachment 173268 [details]
Patch
Comment 2 EFL EWS Bot 2012-11-09 05:11:12 PST 
Comment on attachment 173268 [details]
Patch

Attachment 173268 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14770616
Comment 3 Early Warning System Bot 2012-11-09 05:13:13 PST 
Comment on attachment 173268 [details]
Patch

Attachment 173268 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14683453
Comment 4 Early Warning System Bot 2012-11-09 05:17:31 PST 
Comment on attachment 173268 [details]
Patch

Attachment 173268 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14788132
Comment 5 Ilya Tikhonovsky 2012-11-09 05:17:46 PST 
Created attachment 173271 [details]
for qt bot
Comment 6 Build Bot 2012-11-09 05:54:09 PST 
Comment on attachment 173271 [details]
for qt bot

Attachment 173271 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14778396
Comment 7 Yury Semikhatsky 2012-11-09 05:56:09 PST 
Comment on attachment 173268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173268&action=review

> Source/WebCore/dom/ActiveDOMObject.cpp:98
> +    UNUSED_PARAM(info);

Please remove this.

> Source/WebCore/dom/ContextDestructionObserver.h:43
> +    virtual void reportMemoryUsage(MemoryObjectInfo*) const;

We shouldn't add reportMemoryUsage to abstract interfaces as we don't control their implementations.

> Source/WebCore/dom/WebCoreMemoryInstrumentation.h:48
> +    static MemoryObjectType Audio;

Should go into PlatformMemoryInstrumentation.h
Comment 8 Yury Semikhatsky 2012-11-09 05:58:46 PST 
Except for the comments above the instrumentation looks good. But I'd like someone familiar with web audio code to look at AudioContext::reportMemoryUsage and AutoLocker call in it.
Comment 9 Ilya Tikhonovsky 2012-11-09 06:04:19 PST 
Created attachment 173287 [details]
with fix for mac and win bots.
Comment 10 Build Bot 2012-11-09 07:07:53 PST 
Comment on attachment 173287 [details]
with fix for mac and win bots.

Attachment 173287 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14785201
Comment 11 Build Bot 2012-11-09 07:56:18 PST 
Comment on attachment 173287 [details]
with fix for mac and win bots.

Attachment 173287 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14771712
Comment 12 Ilya Tikhonovsky 2012-11-10 04:14:43 PST 
Created attachment 173442 [details]
with fix for mac, gtk and win bots.
Comment 13 Ilya Tikhonovsky 2012-11-11 23:33:16 PST 
Created attachment 173573 [details]
with additional instrumentation for fft arrays. total ~36mb
Comment 14 Ilya Tikhonovsky 2012-11-11 23:42:54 PST 
(In reply to comment #7)
> (From update of attachment 173268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173268&action=review
> 
> > Source/WebCore/dom/ActiveDOMObject.cpp:98
> > +    UNUSED_PARAM(info);
> 
> Please remove this.

done

> 
> > Source/WebCore/dom/ContextDestructionObserver.h:43
> > +    virtual void reportMemoryUsage(MemoryObjectInfo*) const;
> 
> We shouldn't add reportMemoryUsage to abstract interfaces as we don't control their implementations.

done

> 
> > Source/WebCore/dom/WebCoreMemoryInstrumentation.h:48
> > +    static MemoryObjectType Audio;
> 
> Should go into PlatformMemoryInstrumentation.h

done.
Comment 15 Ilya Tikhonovsky 2012-11-14 04:13:46 PST 
Committed r134593: <http://trac.webkit.org/changeset/134593>
Comment 16 Kentaro Hara 2012-11-14 05:05:56 PST 
It looks like this patch broke inspector-protocol/nmi-webaudio.html. I will mark it as FAIL. Please fix it soon.