Bug 101723 - [EFL][WK2] Add support for custom cursors
Summary: [EFL][WK2] Add support for custom cursors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-09 01:27 PST by Chris Dumez
Modified: 2012-11-09 03:06 PST (History)
8 users (show)

See Also:


Attachments
Patch (7.00 KB, patch)
2012-11-09 01:40 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-11-09 01:27:07 PST
WebKit2 EFL can only handle standard cursors, not custom ones. We should implement this.

Demo:
http://webdesign.about.com/od/examples/l/blstylescursorexamples.htm#fancy
Comment 1 Chris Dumez 2012-11-09 01:40:43 PST
Created attachment 173238 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-09 02:14:57 PST
Comment on attachment 173238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173238&action=review

> Source/WebCore/platform/graphics/efl/ImageEfl.cpp:70
> +Evas_Object* BitmapImage::getEvasObject(Evas* evas)
> +{
> +    NativeImageCairo* image = nativeImageForCurrentFrame();
> +    return image ? evasObjectFromCairoImageSurface(evas, image->surface()).leakRef() : 0;
> +}

In Qt this would be called toEvasObject as it does work and not just returns
Comment 3 Chris Dumez 2012-11-09 02:19:56 PST
(In reply to comment #2)
> (From update of attachment 173238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173238&action=review
> 
> > Source/WebCore/platform/graphics/efl/ImageEfl.cpp:70
> > +Evas_Object* BitmapImage::getEvasObject(Evas* evas)
> > +{
> > +    NativeImageCairo* image = nativeImageForCurrentFrame();
> > +    return image ? evasObjectFromCairoImageSurface(evas, image->surface()).leakRef() : 0;
> > +}
> 
> In Qt this would be called toEvasObject as it does work and not just returns

I kept consistency with other ports:
virtual NSImage* getNSImage() { return 0; }
virtual CGImageRef getCGImageRef() { return 0; }
virtual bool getHBITMAP(HBITMAP) { return false; }
virtual GdkPixbuf* getGdkPixbuf() { return 0; }
Comment 4 WebKit Review Bot 2012-11-09 03:06:44 PST
Comment on attachment 173238 [details]
Patch

Clearing flags on attachment: 173238

Committed r134041: <http://trac.webkit.org/changeset/134041>
Comment 5 WebKit Review Bot 2012-11-09 03:06:51 PST
All reviewed patches have been landed.  Closing bug.