Bug 101723 – [EFL][WK2] Add support for custom cursors

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

WebKit2 EFL can only handle standard cursors, not custom ones. We should implement this.

Demo:
http://webdesign.about.com/od/examples/l/blstylescursorexamples.htm#fancy

[Chris Dumez]

Created attachment 173238 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 173238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173238&action=review

> Source/WebCore/platform/graphics/efl/ImageEfl.cpp:70
> +Evas_Object* BitmapImage::getEvasObject(Evas* evas)
> +{
> +    NativeImageCairo* image = nativeImageForCurrentFrame();
> +    return image ? evasObjectFromCairoImageSurface(evas, image->surface()).leakRef() : 0;
> +}

In Qt this would be called toEvasObject as it does work and not just returns

[Chris Dumez]

(In reply to comment #2)
> (From update of attachment 173238 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173238&action=review
> 
> > Source/WebCore/platform/graphics/efl/ImageEfl.cpp:70
> > +Evas_Object* BitmapImage::getEvasObject(Evas* evas)
> > +{
> > +    NativeImageCairo* image = nativeImageForCurrentFrame();
> > +    return image ? evasObjectFromCairoImageSurface(evas, image->surface()).leakRef() : 0;
> > +}
> 
> In Qt this would be called toEvasObject as it does work and not just returns

I kept consistency with other ports:
virtual NSImage* getNSImage() { return 0; }
virtual CGImageRef getCGImageRef() { return 0; }
virtual bool getHBITMAP(HBITMAP) { return false; }
virtual GdkPixbuf* getGdkPixbuf() { return 0; }

[WebKit Review Bot]

Comment on attachment 173238 [details]
Patch

Clearing flags on attachment: 173238

Committed r134041: <http://trac.webkit.org/changeset/134041>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.