Bug 101711 - People with dichromacy can't tell crashes and passes on flakiness dashboard
Summary: People with dichromacy can't tell crashes and passes on flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 22:31 PST by Ryosuke Niwa
Modified: 2012-11-09 12:16 PST (History)
3 users (show)

See Also:


Attachments
Demo (you need to be a dichromat to see this) (20.13 KB, image/png)
2012-11-08 22:31 PST, Ryosuke Niwa
no flags Details
Color table (after adjustment) (761 bytes, text/html)
2012-11-08 23:02 PST, Ryosuke Niwa
no flags Details
Adjusts the color (1.43 KB, patch)
2012-11-08 23:03 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-11-08 22:31:13 PST
Created attachment 173205 [details]
Demo (you need to be a dichromat to see this)

I am dichromats, and I can't tell the difference between crashes and passes on flakiness dashboard at first glance depending on the color profiles of the display.

e.g. I can't tell where orange turns into green on the attached screenshot.
Comment 1 Ojan Vafai 2012-11-08 23:01:04 PST
I have no problem with picking a different color. The colors picked there were completely arbitrary. I like the following:
green = pass
red = text
blue = image
purple = image+text

Other than that, feel free to change any of the other colors to something that works better for you.
Comment 2 Ryosuke Niwa 2012-11-08 23:01:47 PST
I'll adjust the saturation & brightness.
Comment 3 Ryosuke Niwa 2012-11-08 23:02:19 PST
Created attachment 173209 [details]
Color table (after adjustment)
Comment 4 Ryosuke Niwa 2012-11-08 23:03:24 PST
Created attachment 173210 [details]
Adjusts the color
Comment 5 Dirk Pranke 2012-11-09 09:49:23 PST
Perhaps it makes sense to add something else so that the failure types aren't shown solely by different colors, e.g., "T", "I", "C" as light text, or different patterns on the backgrounds, or something?
Comment 6 Ryosuke Niwa 2012-11-09 12:09:38 PST
(In reply to comment #5)
> Perhaps it makes sense to add something else so that the failure types aren't shown solely by different colors, e.g., "T", "I", "C" as light text, or different patterns on the backgrounds, or something?

Maybe. In general, relying solely on hue & saturation is a really bad idea. There are people with Monochromacy, and everything is gray-scaled to them.
Comment 7 Ojan Vafai 2012-11-09 12:13:34 PST
(In reply to comment #5)
> Perhaps it makes sense to add something else so that the failure types aren't shown solely by different colors, e.g., "T", "I", "C" as light text, or different patterns on the backgrounds, or something?

If someone comes up with a good UI, I'm all for it. At the moment, the contents of each box is the number of seconds that run took. I suppose we could add toggles to hide/show the seconds and/or the abbreviation.
Comment 8 Ryosuke Niwa 2012-11-09 12:15:36 PST
Maybe we can use these patterns? http://lea.verou.me/css3patterns/
Comment 9 Ryosuke Niwa 2012-11-09 12:16:44 PST
Comment on attachment 173210 [details]
Adjusts the color

Clearing flags on attachment: 173210

Committed r134097: <http://trac.webkit.org/changeset/134097>
Comment 10 Ryosuke Niwa 2012-11-09 12:16:45 PST
All reviewed patches have been landed.  Closing bug.