WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
101710
Internals: MockPagePopup should not update DOM structure during detach()
https://bugs.webkit.org/show_bug.cgi?id=101710
Summary
Internals: MockPagePopup should not update DOM structure during detach()
Kent Tamura
Reported
2012-11-08 22:29:13 PST
Internals: MockPagePopup should not update DOM structure during detach()
Attachments
Patch
(21.76 KB, patch)
2012-11-08 22:46 PST
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2012-11-08 22:46:30 PST
Created
attachment 173207
[details]
Patch
Hajime Morrita
Comment 2
2012-11-09 00:58:57 PST
Comment on
attachment 173207
[details]
Patch Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle trick.
Kent Tamura
Comment 3
2012-11-09 01:42:17 PST
(In reply to
comment #2
)
> (From update of
attachment 173207
[details]
) > Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle trick.
Yeah, it would help some. Let me work on it after this patch.
WebKit Review Bot
Comment 4
2012-11-11 17:40:37 PST
Comment on
attachment 173207
[details]
Patch Clearing flags on attachment: 173207 Committed
r134180
: <
http://trac.webkit.org/changeset/134180
>
WebKit Review Bot
Comment 5
2012-11-11 17:40:40 PST
All reviewed patches have been landed. Closing bug.
Kent Tamura
Comment 6
2012-11-11 20:01:59 PST
(In reply to
comment #3
)
> (In reply to
comment #2
) > > (From update of
attachment 173207
[details]
[details]) > > Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle trick. > > Yeah, it would help some. Let me work on it after this patch.
I tried to reduce some code by it, but I couldn't do anything other than removing RefCounted<> inheritance of MockPagePopup and WebPagePopupImpl.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug