Bug 101710 - Internals: MockPagePopup should not update DOM structure during detach()
Summary: Internals: MockPagePopup should not update DOM structure during detach()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 22:29 PST by Kent Tamura
Modified: 2012-11-11 20:01 PST (History)
3 users (show)

See Also:


Attachments
Patch (21.76 KB, patch)
2012-11-08 22:46 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-11-08 22:29:13 PST
Internals: MockPagePopup should not update DOM structure during detach()
Comment 1 Kent Tamura 2012-11-08 22:46:30 PST
Created attachment 173207 [details]
Patch
Comment 2 Hajime Morrita 2012-11-09 00:58:57 PST
Comment on attachment 173207 [details]
Patch

Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle  trick.
Comment 3 Kent Tamura 2012-11-09 01:42:17 PST
(In reply to comment #2)
> (From update of attachment 173207 [details])
> Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle  trick.

Yeah, it would help some.  Let me work on it after this patch.
Comment 4 WebKit Review Bot 2012-11-11 17:40:37 PST
Comment on attachment 173207 [details]
Patch

Clearing flags on attachment: 173207

Committed r134180: <http://trac.webkit.org/changeset/134180>
Comment 5 WebKit Review Bot 2012-11-11 17:40:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Kent Tamura 2012-11-11 20:01:59 PST
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 173207 [details] [details])
> > Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle  trick.
> 
> Yeah, it would help some.  Let me work on it after this patch.

I tried to reduce some code by it, but I couldn't do anything other than removing RefCounted<> inheritance of MockPagePopup and WebPagePopupImpl.