Internals: MockPagePopup should not update DOM structure during detach()
Created attachment 173207 [details] Patch
Comment on attachment 173207 [details] Patch Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle trick.
(In reply to comment #2) > (From update of attachment 173207 [details]) > Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle trick. Yeah, it would help some. Let me work on it after this patch.
Comment on attachment 173207 [details] Patch Clearing flags on attachment: 173207 Committed r134180: <http://trac.webkit.org/changeset/134180>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 173207 [details] [details]) > > Now both MockPagePopup and WebPagePopupImpl are RefCounted. Why not make PagePopup a RefCounted? Then we might be able to get rid of these complicated lifecycle trick. > > Yeah, it would help some. Let me work on it after this patch. I tried to reduce some code by it, but I couldn't do anything other than removing RefCounted<> inheritance of MockPagePopup and WebPagePopupImpl.