Bug 101696 - Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
Summary: Make assumptions about m_parentStyle consistent within StyleResolver::applyPr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 20:23 PST by Luke Macpherson
Modified: 2012-11-15 16:14 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2012-11-08 20:27 PST, Luke Macpherson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-11-08 20:23:11 PST 
Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
Comment 1 Luke Macpherson 2012-11-08 20:27:15 PST 
Created attachment 173187 [details]
Patch
Comment 2 Tony Chang 2012-11-13 10:07:02 PST 
Comment on attachment 173187 [details]
Patch

This looks correct, but I'm curious about the other use of m_parentStyle in StyleResolver::applyProperty.  In the CSSPropertyContent case, we use m_parentStyle. I wonder if that's safe?
Comment 3 Luke Macpherson 2012-11-15 15:57:02 PST 
I see what you mean. It's hard to reason about the initialization state of StyleResolver right now to give a hard answer to that question.
Comment 4 WebKit Review Bot 2012-11-15 16:14:04 PST 
Comment on attachment 173187 [details]
Patch

Clearing flags on attachment: 173187

Committed r134846: <http://trac.webkit.org/changeset/134846>
Comment 5 WebKit Review Bot 2012-11-15 16:14:08 PST 
All reviewed patches have been landed.  Closing bug.