Bug 101693 - Web Inspector: Always use textured window for the Web Inspector
Summary: Web Inspector: Always use textured window for the Web Inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 19:44 PST by Timothy Hatcher
Modified: 2012-11-08 22:47 PST (History)
9 users (show)

See Also:

Attachments
Proposed Change (5.50 KB, patch)
2012-11-08 19:47 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2012-11-08 19:44:56 PST 
Use textured window for the Web Inspector window.
Comment 1 Timothy Hatcher 2012-11-08 19:47:55 PST 
Created attachment 173180 [details]
Proposed Change
Comment 2 Joseph Pecoraro 2012-11-08 20:09:20 PST 
Comment on attachment 173180 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=173180&action=review

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:344
> +    [window setContentBorderThickness:55. forEdge:NSMaxYEdge];

Nit: "55." isn't normal number style. You can fix this, or just cq+ since its not changing from the old code.
Comment 3 WebKit Review Bot 2012-11-08 22:47:20 PST 
Comment on attachment 173180 [details]
Proposed Change

Clearing flags on attachment: 173180

Committed r134015: <http://trac.webkit.org/changeset/134015>
Comment 4 WebKit Review Bot 2012-11-08 22:47:23 PST 
All reviewed patches have been landed.  Closing bug.