RESOLVED FIXED 101689
[BlackBerry] remove obsolete tokenizer settings 
https://bugs.webkit.org/show_bug.cgi?id=101689
Summary [BlackBerry] remove obsolete tokenizer settings
George Staikos
Reported 2012-11-08 18:50:41 PST
WebPage has custom tweaks for the tokenizer that should not be there. Remove them.
Attachments
Patch (1.40 KB, patch)
2012-11-08 18:53 PST, George Staikos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
George Staikos
Comment 1 2012-11-08 18:53:38 PST
Created attachment 173173 [details] Patch
Rob Buis
Comment 2 2012-11-08 19:34:01 PST
Comment on attachment 173173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173173&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:-575 > - m_page->setCustomHTMLTokenizerTimeDelay(0.3); These are still in use : http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp Does this mean the default behavior is fine for us?
George Staikos
Comment 3 2012-11-08 20:21:49 PST
yes
Yong Li
Comment 4 2012-11-09 07:27:56 PST
Comment on attachment 173173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173173&action=review >> Source/WebKit/blackberry/Api/WebPage.cpp:-575 >> - m_page->setCustomHTMLTokenizerTimeDelay(0.3); > > These are still in use : > > http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp > > Does this mean the default behavior is fine for us? I think so. I am surprised by the number "256". I believe it hurts...
WebKit Review Bot
Comment 5 2012-11-09 07:32:47 PST
Comment on attachment 173173 [details] Patch Clearing flags on attachment: 173173 Committed r134067: <http://trac.webkit.org/changeset/134067>
WebKit Review Bot
Comment 6 2012-11-09 07:32:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.