Bug 101689 - [BlackBerry] remove obsolete tokenizer settings
Summary: [BlackBerry] remove obsolete tokenizer settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 18:50 PST by George Staikos
Modified: 2012-11-09 07:32 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2012-11-08 18:53 PST, George Staikos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-11-08 18:50:41 PST
WebPage has custom tweaks for the tokenizer that should not be there.  Remove them.
Comment 1 George Staikos 2012-11-08 18:53:38 PST
Created attachment 173173 [details]
Patch
Comment 2 Rob Buis 2012-11-08 19:34:01 PST
Comment on attachment 173173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173173&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:-575
> -    m_page->setCustomHTMLTokenizerTimeDelay(0.3);

These are still in use :

http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp

Does this mean the default behavior is fine for us?
Comment 3 George Staikos 2012-11-08 20:21:49 PST
yes
Comment 4 Yong Li 2012-11-09 07:27:56 PST
Comment on attachment 173173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173173&action=review

>> Source/WebKit/blackberry/Api/WebPage.cpp:-575
>> -    m_page->setCustomHTMLTokenizerTimeDelay(0.3);
> 
> These are still in use :
> 
> http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp
> 
> Does this mean the default behavior is fine for us?

I think so. I am surprised by the number "256". I believe it hurts...
Comment 5 WebKit Review Bot 2012-11-09 07:32:47 PST
Comment on attachment 173173 [details]
Patch

Clearing flags on attachment: 173173

Committed r134067: <http://trac.webkit.org/changeset/134067>
Comment 6 WebKit Review Bot 2012-11-09 07:32:50 PST
All reviewed patches have been landed.  Closing bug.