Bug 101675 - [TexMap] Initialize m_compositedNativeImagePtr in GraphicsLayerTextureMapper.
Summary: [TexMap] Initialize m_compositedNativeImagePtr in GraphicsLayerTextureMapper.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dongseong Hwang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 17:40 PST by Dongseong Hwang
Modified: 2012-11-09 17:46 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.31 KB, patch)
2012-11-08 17:41 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2012-11-09 16:17 PST, Dongseong Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dongseong Hwang 2012-11-08 17:40:09 PST
Fix a potential bug in GraphicsLayerTextureMapper. If the member's uninitialized
value equals image->nativeImageForCurrentFrame() by change, we can encounter
undefined behavior.
Comment 1 Dongseong Hwang 2012-11-08 17:41:55 PST
Created attachment 173160 [details]
Patch
Comment 2 Noam Rosenthal 2012-11-08 20:00:01 PST
Comment on attachment 173160 [details]
Patch

Any way to test this?
Comment 3 Dongseong Hwang 2012-11-08 21:59:53 PST
(In reply to comment #2)
> (From update of attachment 173160 [details])
> Any way to test this?

I think it is hard because m_compositedNativeImagePtr is initialized to random value.

m_compositedNativeImagePtr is used only in
if (newNativeImagePtr == m_compositedNativeImagePtr)
    return;

If we want to make a test, the test must have the ability to check the above code. Unfortunately, I can not imagine.
Comment 4 WebKit Review Bot 2012-11-09 07:28:56 PST
Comment on attachment 173160 [details]
Patch

Rejecting attachment 173160 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 6360 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 6360.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14790103
Comment 5 Dongseong Hwang 2012-11-09 16:17:30 PST
Created attachment 173391 [details]
Patch
Comment 6 Dongseong Hwang 2012-11-09 16:18:23 PST
Thanks for review! Could you r+ one more time? commit-queue failed flaky.
Comment 7 WebKit Review Bot 2012-11-09 17:46:53 PST
Comment on attachment 173391 [details]
Patch

Clearing flags on attachment: 173391

Committed r134140: <http://trac.webkit.org/changeset/134140>
Comment 8 WebKit Review Bot 2012-11-09 17:46:57 PST
All reviewed patches have been landed.  Closing bug.