WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
101654
Node::removedFrom could be renamed
https://bugs.webkit.org/show_bug.cgi?id=101654
Summary
Node::removedFrom could be renamed
Stephen Chenney
Reported
2012-11-08 15:20:31 PST
Node::removedFrom is not called when a node is removed due to Document::removedLastRef. In that case, as an optimization, we just call the destructor (it is also rumored that this is the reason we do not issue onunload on frame destruction). We need a better name for removedFrom, or some other mechanism, to remind implementors that anything they do to clean up pointers etc must be done in both the destructor and removedFrom.
Attachments
Add attachment
proposed patch, testcase, etc.
Stephen Chenney
Comment 1
2012-11-08 16:11:41 PST
See
http://trac.webkit.org/changeset/113852
as another example of a bug due to this behavior.
Abhishek Arya
Comment 2
2012-11-15 16:15:33 PST
and
https://bugs.webkit.org/show_bug.cgi?id=101505
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug