Bug 101652 - [BlackBerry] Replace checkerboard with page background color
Summary: [BlackBerry] Replace checkerboard with page background color
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 15:11 PST by Jakob Petsovits
Modified: 2012-11-08 17:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.80 KB, patch)
2012-11-08 15:16 PST, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-11-08 15:11:52 PST
Seems the trend is to go to solid color instead of a more distinguishable checkerboard pattern. It was decided that we should follow suit.

In order to do this, here's a new member variable for BackingStore because when blitting, we can't access the page background color in a threadsafe way.
Solid background color fill is still only used for public builds. Developers and beta testers should still see checkerboard and do something about it.

Also tracked as RIM PR 188235. Patch below.
Comment 1 Jakob Petsovits 2012-11-08 15:16:57 PST
Created attachment 173132 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-08 17:25:48 PST
Comment on attachment 173132 [details]
Patch

Clearing flags on attachment: 173132

Committed r133979: <http://trac.webkit.org/changeset/133979>
Comment 3 WebKit Review Bot 2012-11-08 17:25:51 PST
All reviewed patches have been landed.  Closing bug.