Bug 101646 - [BlackBerry] Disable cookies on file://
Summary: [BlackBerry] Disable cookies on file://
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 14:34 PST by otcheung
Modified: 2012-11-08 15:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2012-11-08 14:42 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (5.58 KB, patch)
2012-11-08 14:47 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (5.80 KB, patch)
2012-11-08 14:57 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (5.90 KB, patch)
2012-11-08 15:08 PST, otcheung 		no flags Details | Formatted Diff | Diff
Patch (5.90 KB, patch)
2012-11-08 15:13 PST, otcheung 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description otcheung 2012-11-08 14:34:17 PST 
Disabling cookies on file:// on browser app
Comment 1 otcheung 2012-11-08 14:42:11 PST 
Created attachment 173121 [details]
Patch
Comment 2 otcheung 2012-11-08 14:47:41 PST 
Created attachment 173123 [details]
Patch
Comment 3 Rob Buis 2012-11-08 14:54:30 PST 
Comment on attachment 173123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173123&action=review

Almost there.

> Source/WebCore/platform/blackberry/CookieManager.cpp:129
> +static bool shouldIgnoreScheme(const String protocol)

Use &.

> Source/WebCore/platform/blackberry/CookieManager.cpp:243
> +    // We only want to enable them if the webworks app enabled a flag for it (m_shouldDumpAllCookies)

Periods at end of sentences.
Comment 4 otcheung 2012-11-08 14:57:52 PST 
Created attachment 173127 [details]
Patch
Comment 5 Rob Buis 2012-11-08 15:04:36 PST 
Comment on attachment 173127 [details]
Patch

LGTM.
Comment 6 otcheung 2012-11-08 15:08:33 PST 
Created attachment 173128 [details]
Patch
Comment 7 otcheung 2012-11-08 15:13:16 PST 
Created attachment 173131 [details]
Patch
Comment 8 Rob Buis 2012-11-08 15:13:55 PST 
Comment on attachment 173131 [details]
Patch

LGTM.
Comment 9 WebKit Review Bot 2012-11-08 15:50:31 PST 
Comment on attachment 173131 [details]
Patch

Clearing flags on attachment: 173131

Committed r133964: <http://trac.webkit.org/changeset/133964>
Comment 10 WebKit Review Bot 2012-11-08 15:50:34 PST 
All reviewed patches have been landed.  Closing bug.