RESOLVED FIXED 101646
[BlackBerry] Disable cookies on file:// 
https://bugs.webkit.org/show_bug.cgi?id=101646
Summary [BlackBerry] Disable cookies on file://
otcheung
Reported 2012-11-08 14:34:17 PST
Disabling cookies on file:// on browser app
Attachments
Patch (5.58 KB, patch)
2012-11-08 14:42 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (5.58 KB, patch)
2012-11-08 14:47 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (5.80 KB, patch)
2012-11-08 14:57 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2012-11-08 15:08 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2012-11-08 15:13 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-11-08 14:42:11 PST
Created attachment 173121 [details] Patch
otcheung
Comment 2 2012-11-08 14:47:41 PST
Created attachment 173123 [details] Patch
Rob Buis
Comment 3 2012-11-08 14:54:30 PST
Comment on attachment 173123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173123&action=review Almost there. > Source/WebCore/platform/blackberry/CookieManager.cpp:129 > +static bool shouldIgnoreScheme(const String protocol) Use &. > Source/WebCore/platform/blackberry/CookieManager.cpp:243 > + // We only want to enable them if the webworks app enabled a flag for it (m_shouldDumpAllCookies) Periods at end of sentences.
otcheung
Comment 4 2012-11-08 14:57:52 PST
Created attachment 173127 [details] Patch
Rob Buis
Comment 5 2012-11-08 15:04:36 PST
Comment on attachment 173127 [details] Patch LGTM.
otcheung
Comment 6 2012-11-08 15:08:33 PST
Created attachment 173128 [details] Patch
otcheung
Comment 7 2012-11-08 15:13:16 PST
Created attachment 173131 [details] Patch
Rob Buis
Comment 8 2012-11-08 15:13:55 PST
Comment on attachment 173131 [details] Patch LGTM.
WebKit Review Bot
Comment 9 2012-11-08 15:50:31 PST
Comment on attachment 173131 [details] Patch Clearing flags on attachment: 173131 Committed r133964: <http://trac.webkit.org/changeset/133964>
WebKit Review Bot
Comment 10 2012-11-08 15:50:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.