Bug 101642 – MarkStackArray should use the BlockAllocator instead of the MarkStackSegmentAllocator

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

MarkStackSegmentAllocator is like a miniature version of the BlockAllocator. Now that the BlockAllocator has support for a variety of block sizes, we should get rid of the MarkStackSegmentAllocator in favor of the BlockAllocator.

[Mark Hahnenberg]

Created attachment 173116 [details]
Patch

[Filip Pizlo]

Comment on attachment 173116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173116&action=review

> Source/JavaScriptCore/heap/BlockAllocator.h:326
> +    return m_weakRegionSet;

Then can you rename m_weakRegionSet to something that reflects its dual purpose?

[Mark Hahnenberg]

Created attachment 173124 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 173124 [details]
Patch

Attachment 173124 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14763806

[WebKit Review Bot]

Comment on attachment 173124 [details]
Patch

Rejecting attachment 173124 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ing file Source/JavaScriptCore/heap/MarkStackInlineMethods.h
Hunk #1 FAILED at 31.
Hunk #2 FAILED at 69.
Hunk #3 FAILED at 79.
Hunk #4 FAILED at 89.
Hunk #5 FAILED at 105.
5 out of 5 hunks FAILED -- saving rejects to file Source/JavaScriptCore/heap/MarkStackInlineMethods.h.rej
patching file Source/JavaScriptCore/heap/SlotVisitor.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14778471

[Mark Hahnenberg]

Committed r134080: <http://trac.webkit.org/changeset/134080>