RESOLVED WONTFIX 101629
[chromium] Adding a number of layers in layer tree to WebRenderingStats. 
https://bugs.webkit.org/show_bug.cgi?id=101629
Summary [chromium] Adding a number of layers in layer tree to WebRenderingStats.
Glenn Hartmann
Reported 2012-11-08 11:43:42 PST
[chromium] Adding a number of layers in layer tree to WebRenderingStats.
Attachments
Patch (1.92 KB, patch)
2012-11-08 11:44 PST, Glenn Hartmann 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Glenn Hartmann
Comment 1 2012-11-08 11:44:16 PST
Created attachment 173084 [details] Patch
Glenn Hartmann
Comment 2 2012-11-08 11:44:39 PST
jamesr@ Please take a look
WebKit Review Bot
Comment 3 2012-11-08 11:49:00 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2012-11-08 15:55:24 PST
Do we need this? Can't it just go through the chromium repo?
Nat Duca
Comment 5 2012-11-08 19:26:20 PST
Not yet, because the struct is passed by value instead of as a ptr. That prevents a static cast back to the cc type. We were going to fix this, but we've been holding off because we're planning on doing something completely different for stats [sending stats via inspector].
James Robinson
Comment 6 2012-11-09 10:44:44 PST
(In reply to comment #5) > Not yet, because the struct is passed by value instead of as a ptr. That prevents a static cast back to the cc type. Where? The only places I see this struct being used in WebKit are by const reference. > > We were going to fix this, but we've been holding off because we're planning on doing something completely different for stats [sending stats via inspector].
Note You need to log in before you can comment on or make changes to this bug.