Bug 101629 - [chromium] Adding a number of layers in layer tree to WebRenderingStats.
Summary: [chromium] Adding a number of layers in layer tree to WebRenderingStats.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 11:43 PST by Glenn Hartmann
Modified: 2012-11-27 06:20 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2012-11-08 11:44 PST, Glenn Hartmann
jamesr: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn Hartmann 2012-11-08 11:43:42 PST
[chromium] Adding a number of layers in layer tree to WebRenderingStats.
Comment 1 Glenn Hartmann 2012-11-08 11:44:16 PST
Created attachment 173084 [details]
Patch
Comment 2 Glenn Hartmann 2012-11-08 11:44:39 PST
jamesr@ Please take a look
Comment 3 WebKit Review Bot 2012-11-08 11:49:00 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 James Robinson 2012-11-08 15:55:24 PST
Do we need this?  Can't it just go through the chromium repo?
Comment 5 Nat Duca 2012-11-08 19:26:20 PST
Not yet, because the struct is passed by value instead of as a ptr. That prevents a static cast back to the cc type.

We were going to fix this, but we've been holding off because we're planning on doing something completely different for stats [sending stats via inspector].
Comment 6 James Robinson 2012-11-09 10:44:44 PST
(In reply to comment #5)
> Not yet, because the struct is passed by value instead of as a ptr. That prevents a static cast back to the cc type.

Where?  The only places I see this struct being used in WebKit are by const reference.

> 
> We were going to fix this, but we've been holding off because we're planning on doing something completely different for stats [sending stats via inspector].