Bug 101628 – [BlackBerry] Provide pixel coordinates to IMF relative to the screen

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Nima Ghanavatian]

We need to account for webkit based fields that do not necessarily own the entire screen and start at 0,0 from the screen.

[Nima Ghanavatian]

Created attachment 173085 [details]
Patch

[WebKit Review Bot]

Attachment 173085 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:753:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:754:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Comment on attachment 173085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173085&action=review

Some stuff to fix still.

> Source/WebKit/blackberry/ChangeLog:8
> +        Need the bug URL (OOPS!).

You have two descriptions :) Please merge them.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:758
> +                           , spellCheckingOptionRequest.startTextPosition, spellCheckingOptionRequest.endTextPosition);

The IntPoint will not work with %d.

[Nima Ghanavatian]

Created attachment 173092 [details]
Patch

[WebKit Review Bot]

Attachment 173092 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:753:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Comment on attachment 173092 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 173092 [details]
Patch

Rejecting attachment 173092 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
eLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Wrong error type is thrown for type errors in callbacks

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14770327

[WebKit Review Bot]

Comment on attachment 173092 [details]
Patch

Clearing flags on attachment: 173092

Committed r133951: <http://trac.webkit.org/changeset/133951>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.