Bug 101624 - 4.68MB below RenderStyle::filter() on Membuster3.
Summary: 4.68MB below RenderStyle::filter() on Membuster3.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-08 10:27 PST by Andreas Kling
Modified: 2012-11-08 11:38 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2012-11-08 10:35 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Same patch, glitzier ChangeLog (954 bytes, patch)
2012-11-08 10:43 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
How hard can it be? (3.11 KB, patch)
2012-11-08 10:45 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-11-08 10:27:24 PST
There's a const overload of RenderStyle::filter() that doesn't copy-on-write the inherited data, but this almost never gets picked since calls typically go through a RenderStyle*.
Comment 1 Radar WebKit Bug Importer 2012-11-08 10:33:27 PST
<rdar://problem/12663822>
Comment 2 Andreas Kling 2012-11-08 10:35:50 PST
Created attachment 173069 [details]
Patch
Comment 3 Andreas Kling 2012-11-08 10:42:21 PST
Actually, the total wasted memory is 4.68MB (additional cost from no longer sharing the StyleRareNonInheritedData.)

More savings, yay! \o/
Comment 4 Andreas Kling 2012-11-08 10:43:36 PST
Created attachment 173070 [details]
Same patch, glitzier ChangeLog
Comment 5 Andreas Kling 2012-11-08 10:45:54 PST
Created attachment 173071 [details]
How hard can it be?
Comment 6 Dirk Schulze 2012-11-08 11:02:40 PST
(In reply to comment #3)
> Actually, the total wasted memory is 4.68MB (additional cost from no longer sharing the StyleRareNonInheritedData.)
> 
> More savings, yay! \o/

Awesome catch!
Comment 7 WebKit Review Bot 2012-11-08 11:38:19 PST
Comment on attachment 173071 [details]
How hard can it be?

Clearing flags on attachment: 173071

Committed r133926: <http://trac.webkit.org/changeset/133926>
Comment 8 WebKit Review Bot 2012-11-08 11:38:24 PST
All reviewed patches have been landed.  Closing bug.