Introduce WebScreenInfo.deviceScaleFactor
Created attachment 173054 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Please see http://codereview.chromium.org/11348033/#msg23 for the rationale.
> 3. [WebKit] Remove WebCore::screen{Horizontal,Vertical}DPI() and use WebScreenInfo::deviceScaleFactor in ChromeClientImpl::dispatchViewportPropertiesDidChange. ^^^ That's very exciting.
Comment on attachment 173054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173054&action=review > Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm:98 > float deviceDPI = 160 * deviceScaleFactor(view); Should we avoid calling deviceScaleFactor twice?
(In reply to comment #5) > Should we avoid calling deviceScaleFactor twice? I was going to do that in step 5 when horizontal/verticalDPI go away for good.
Comment on attachment 173054 [details] Patch Rejecting attachment 173054 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: omium/TestExpectations Failed to merge in the changes. Patch failed at 0001 Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14764668
Comment on attachment 173054 [details] Patch Clearing flags on attachment: 173054 Committed r133927: <http://trac.webkit.org/changeset/133927>
All reviewed patches have been landed. Closing bug.