WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
101610
[BlackBerry] Janitor: Remove unused m_isValid bool
https://bugs.webkit.org/show_bug.cgi?id=101610
Summary
[BlackBerry] Janitor: Remove unused m_isValid bool
Jakob Petsovits
Reported
2012-11-08 08:32:38 PST
It's not used anywhere, but as we have a constructor that creates an invalid TileIndex, let's add another method to check validity - now a correct check. On top of that, make the stylebot happy by reducing "unsigned int" to just "unsigned". Patch below.
Attachments
Patch
(2.98 KB, patch)
2012-11-08 08:35 PST
,
Jakob Petsovits
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jakob Petsovits
Comment 1
2012-11-08 08:35:46 PST
Created
attachment 173050
[details]
Patch
Rob Buis
Comment 2
2012-11-08 08:48:15 PST
Comment on
attachment 173050
[details]
Patch LGTM.
WebKit Review Bot
Comment 3
2012-11-08 12:08:32 PST
Comment on
attachment 173050
[details]
Patch Clearing flags on attachment: 173050 Committed
r133928
: <
http://trac.webkit.org/changeset/133928
>
WebKit Review Bot
Comment 4
2012-11-08 12:08:36 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug