Bug 101608 - [BlackBerry] Rework the API to use document coordinates
Summary: [BlackBerry] Rework the API to use document coordinates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 08:13 PST by Jakob Petsovits
Modified: 2012-11-08 10:21 PST (History)
8 users (show)

See Also:

Attachments
Patch (64.33 KB, patch)
2012-11-08 08:26 PST, Jakob Petsovits 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2012-11-08 08:13:32 PST 
Scrolling and zooming APIs used to operate on transformed coordinates, which is a bad idea: The UI thread might long have moved on to a different scale and scroll position so outdated pixel coordinates are of limited value.

Moreover, more transformation calculations are needed than if we operate purely on document coordinates.

With webkitThreadViewportAccessor() exposed, the caller has a choice between how to handle coordinates and the means to perform conversions with little effort and overhead if needed. Therefore, we should remove pixel coordinates from the public API. The patch below makes this change.

Internally tracked as part of RIM PR 173292.
Comment 1 Jakob Petsovits 2012-11-08 08:26:21 PST 
Created attachment 173049 [details]
Patch
Comment 2 Adam Treat 2012-11-08 08:54:20 PST 
Comment on attachment 173049 [details]
Patch

This is the way we are going so r+
Comment 3 WebKit Review Bot 2012-11-08 10:21:53 PST 
Comment on attachment 173049 [details]
Patch

Clearing flags on attachment: 173049

Committed r133914: <http://trac.webkit.org/changeset/133914>
Comment 4 WebKit Review Bot 2012-11-08 10:21:56 PST 
All reviewed patches have been landed.  Closing bug.