Bug 101605 – Web Inspector: Add UA Strings for iOS6 as well as IE Mobile 9 & 10

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Konrad Piascik]

Web Inspector: Add UA Strings for iOS6 as well as IE Mobile 9 & 10

[Konrad Piascik]

Created attachment 173051 [details]
Patch

[Konrad Piascik]

Comment on attachment 173051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173051&action=review

> Source/WebCore/inspector/front-end/SettingsScreen.js:429
> +            ["Internet Explorer Mobile 10 \u2014 Lumina 920", "Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; NOKIA; Lumia 920)", "768x1280x1"]
> +            ["Internet Explorer Mobile 9 \u2014 Lumina 900", "Mozilla/5.0 (compatible; MSIE 9.0; Windows Phone OS 7.5; Trident/5.0; IEMobile/9.0; NOKIA; Lumia 900)", "480x800x1"]

forgot trailing commas, updating...

[Konrad Piascik]

Created attachment 173052 [details]
Patch

[Konrad Piascik]

update component

[Pavel Feldman]

Comment on attachment 173052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173052&action=review

> Source/WebCore/inspector/front-end/SettingsScreen.js:428
> +            ["Internet Explorer Mobile 10 \u2014 Lumina 920", "Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; NOKIA; Lumia 920)", "768x1280x1"],

It started as sorted by potential popularity, so sounds like Lumina should not be this high. But now that the list is so big, we should probably switch to alphabetical sorting.

[Konrad Piascik]

Created attachment 175794 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 175794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175794&action=review

> Source/WebCore/inspector/front-end/SettingsScreen.js:429
> +            ["Android 4.0.2 \u2014 Galaxy Nexus", "Mozilla/5.0 (Linux; U; Android 4.0.2; en-us; Galaxy Nexus Build/ICL53F) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30", "720x1280x1.1"],

Version sorting is messed up: IE and IOS versions are in descending order, Android versions are in ascending one while FF versions are in a mixed order. We should sort them consistently, probably using Array.sort and adding "Other..." to the end?

[PhistucK]

Konrad seems not to work on this, so may I take this?
There is very little work is left to commit this change anyway.

I tried to use sort, but it resulted in a weird order. For example -
Meego
aiPhone
iPhone

Instead of -
aiPhone
iPhone
Meego

This is basically how I sorted the array -
userAgents.sort(function (a, b)
        {
         return a[0] > b[0] ? 1 : -1;
        });

So I reordered the array by hand, alphabetically (newest versions come last).

[PhistucK]

*little work left

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.