Expose a new method to check whether a vector of loaded languages is empty. WK2-EFL needs it to set the default language (if the client didn't set any) when spelling setting is being enabled. This change allows to do not get vector of dictionaries to just check its size.
Created attachment 172972 [details] proposed patch
Comment on attachment 172972 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172972&action=review Mostly a readability/hackability change, so I'll be nit-picky and say languagesLoaded sounds to me like it would return the languages that have been loaded. Also, I'd prefer maintaining the "dictionary" terminology, so perhaps hasDictionary? > Source/WebCore/ChangeLog:11 > + spelling setting is being enabled. This change allows to do not get > + vector of dictionaries to just check its size. This last sentence is a bit broken. How about "This change makes it more convenient to check whether the dictionaries vector is empty."?
Created attachment 173027 [details] apply Gustavo's suggestions
Comment on attachment 173027 [details] apply Gustavo's suggestions Clearing flags on attachment: 173027 Committed r134021: <http://trac.webkit.org/changeset/134021>
All reviewed patches have been landed. Closing bug.