Bug 101568 - [BlackBerry] need to call closePopup at setValueAndClosePopup
Summary: [BlackBerry] need to call closePopup at setValueAndClosePopup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 02:33 PST by Chris.Guan
Modified: 2012-11-08 20:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2012-11-08 03:09 PST, Chris.Guan 		no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2012-11-08 17:48 PST, Chris.Guan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris.Guan 2012-11-08 02:33:54 PST 
When early return occurs, we need to call closePopup function.
Comment 1 Chris.Guan 2012-11-08 03:09:14 PST 
Created attachment 172981 [details]
Patch
Comment 2 Mike Fenton 2012-11-08 04:41:35 PST 
Comment on attachment 172981 [details]
Patch

Looks good to me, Rob?
Comment 3 Rob Buis 2012-11-08 07:31:27 PST 
Comment on attachment 172981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172981&action=review

Code looks good but ChangeLog should be better.

> Source/WebKit/blackberry/ChangeLog:10
> +        Internally reviewed by Charles Wei.

Please also state PR and internal reviewer.
I think the description could be better, since in the PR it states there is a freeze/crash which I can't see in this description.
Comment 4 Chris.Guan 2012-11-08 17:48:52 PST 
Created attachment 173161 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-08 20:16:00 PST 
Comment on attachment 173161 [details]
Patch

Clearing flags on attachment: 173161

Committed r133999: <http://trac.webkit.org/changeset/133999>
Comment 6 WebKit Review Bot 2012-11-08 20:16:03 PST 
All reviewed patches have been landed.  Closing bug.