Bug 101560 - Web Inspector: No content available for requests made from flash
Summary: Web Inspector: No content available for requests made from flash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-08 00:55 PST by Vsevolod Vlasov
Modified: 2012-11-14 01:31 PST (History)
12 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2012-11-08 03:06 PST, Vsevolod Vlasov 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-11-08 00:55:37 PST 
Patch to follow
Comment 1 Vsevolod Vlasov 2012-11-08 03:06:19 PST 
Created attachment 172978 [details]
Patch
Comment 2 Andrey Kosyakov 2012-11-08 03:20:44 PST 
Comment on attachment 172978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172978&action=review

LGTM

> Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> +        if (resourceData && !m_loadingXHRSynchronously && (!resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode())))

nit: extract bool missingCachedResourceData = !resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode()
for better readability.
Comment 3 Vsevolod Vlasov 2012-11-08 03:37:17 PST 
> > Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> > +        if (resourceData && !m_loadingXHRSynchronously && (!resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode())))
> 
> nit: extract bool missingCachedResourceData = !resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode()
> for better readability.

I don't think it would be more readable as I would also need to add a nullity check for resourceData as well anyway.
Comment 4 Andrey Kosyakov 2012-11-08 03:49:08 PST 
> I don't think it would be more readable as I would also need to add a nullity check for resourceData as well anyway.

Indeed -- please disregard this remark.
Comment 5 WebKit Review Bot 2012-11-13 02:10:59 PST 
Comment on attachment 172978 [details]
Patch

Rejecting attachment 172978 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14825155
Comment 6 Vsevolod Vlasov 2012-11-14 01:31:19 PST 
Committed r134574: <http://trac.webkit.org/changeset/134574>