Bug 101560 – Web Inspector: No content available for requests made from flash

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Patch to follow

[Vsevolod Vlasov]

Created attachment 172978 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 172978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172978&action=review

LGTM

> Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> +        if (resourceData && !m_loadingXHRSynchronously && (!resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode())))

nit: extract bool missingCachedResourceData = !resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode()
for better readability.

[Vsevolod Vlasov]

> > Source/WebCore/inspector/InspectorResourceAgent.cpp:294
> > +        if (resourceData && !m_loadingXHRSynchronously && (!resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode())))
> 
> nit: extract bool missingCachedResourceData = !resourceData->cachedResource() || !resourceData->cachedResource()->shouldBufferData() || isErrorStatusCode(resourceData->httpStatusCode()
> for better readability.

I don't think it would be more readable as I would also need to add a nullity check for resourceData as well anyway.

[Andrey Kosyakov]

> I don't think it would be more readable as I would also need to add a nullity check for resourceData as well anyway.

Indeed -- please disregard this remark.

[WebKit Review Bot]

Comment on attachment 172978 [details]
Patch

Rejecting attachment 172978 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14825155

[Vsevolod Vlasov]

Committed r134574: <http://trac.webkit.org/changeset/134574>