Bug 101556 - Add tests for month picker
Summary: Add tests for month picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 100938
  Show dependency tree / graph
 
Reported: 2012-11-07 23:46 PST by Keishi Hattori
Modified: 2012-11-12 04:32 PST (History)
2 users (show)

See Also:

Attachments
Patch (76.42 KB, patch)
2012-11-09 03:49 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (76.42 KB, patch)
2012-11-11 20:44 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (76.55 KB, patch)
2012-11-11 23:23 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-11-07 23:46:49 PST 
Add tests for month picker
Comment 1 Keishi Hattori 2012-11-09 03:49:17 PST 
Created attachment 173259 [details]
Patch
Comment 2 Keishi Hattori 2012-11-11 20:44:31 PST 
Created attachment 173544 [details]
Patch
Comment 3 Kent Tamura 2012-11-11 21:10:58 PST 
Comment on attachment 173544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173544&action=review

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:80
> +    eventSender.keyDown('\n');
> +    shouldBeNull('document.getElementById("mock-page-popup")');

Unfortunately this doesn't work any more because popup close operation is now asynchronous.
http://trac.webkit.org/changeset/134180

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:102
> +    eventSender.keyDown('\x1B');
> +    shouldBeNull('document.getElementById("mock-page-popup")');

ditto.

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:44
> +    clickElement(popupWindow.document.querySelectorAll(".day:not(.week-column)")[6]);
> +    shouldBeNull('document.getElementById("mock-page-popup")');

Ditto.

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html:31
> +    // Close popup
> +    eventSender.keyDown('\x1B');
> +
> +    document.getElementById('month').min = "2011-05";
> +    document.getElementById('month').value = "2012-02";
> +    
> +    // Reopen popup
> +    openPicker(document.getElementById('month'), test2);

ditto.
Comment 4 Keishi Hattori 2012-11-11 23:23:59 PST 
Created attachment 173569 [details]
Patch
Comment 5 Kent Tamura 2012-11-12 00:27:43 PST 
Comment on attachment 173569 [details]
Patch

looks good
Comment 6 WebKit Review Bot 2012-11-12 04:32:34 PST 
Comment on attachment 173569 [details]
Patch

Clearing flags on attachment: 173569

Committed r134209: <http://trac.webkit.org/changeset/134209>
Comment 7 WebKit Review Bot 2012-11-12 04:32:37 PST 
All reviewed patches have been landed.  Closing bug.