Bug 101555 – Add tests for week picker

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Add tests for week picker

[Keishi Hattori]

Created attachment 173632 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173632 [details]
Patch

Attachment 173632 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14804683

New failing tests:
platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html
platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html
platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html

[Kent Tamura]

Comment on attachment 173632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review

> LayoutTests/ChangeLog:11
> +        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.

nit: Don't you make the selection blue border rounded-corners?

> LayoutTests/ChangeLog:22
> +

Please update TextExpectations for pixel tests and the F4 difference of week-picker-key-operations.html.

[Keishi Hattori]

Comment on attachment 173632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review

>> LayoutTests/ChangeLog:11
>> +        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
> 
> nit: Don't you make the selection blue border rounded-corners?

This is intensional. If we round the corners the white background shows through at each corner.

[Kent Tamura]

Comment on attachment 173632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review

>>> LayoutTests/ChangeLog:11
>>> +        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
>> 
>> nit: Don't you make the selection blue border rounded-corners?
> 
> This is intensional. If we round the corners the white background shows through at each corner.

ok, I understand.

[Keishi Hattori]

Created attachment 173786 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173786 [details]
Patch

Rejecting attachment 173786 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html
platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html
Full output: http://queues.webkit.org/results/14817497

[Keishi Hattori]

Created attachment 173829 [details]
Patch

[Kent Tamura]

Comment on attachment 173829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173829&action=review

> LayoutTests/platform/chromium/TestExpectations:4190
> +webkit.org/b/101561 platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ ImageOnlyFailure Pass ]
> +webkit.org/b/101561 platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ ImageOnlyFailure Pass ]
> +

CQ result was Missing.

Regressions: Unexpected missing results (2)
  platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ Missing ]
  platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ Missing ]

[WebKit Review Bot]

Comment on attachment 173829 [details]
Patch

Rejecting attachment 173829 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14822331

[WebKit Review Bot]

Comment on attachment 173829 [details]
Patch

Rejecting attachment 173829 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14809826

[WebKit Review Bot]

Comment on attachment 173829 [details]
Patch

Clearing flags on attachment: 173829

Committed r134731: <http://trac.webkit.org/changeset/134731>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.