Bug 101555 - Add tests for week picker
Summary: Add tests for week picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 100938
  Show dependency treegraph
 
Reported: 2012-11-07 23:45 PST by Keishi Hattori
Modified: 2012-11-14 19:53 PST (History)
3 users (show)

See Also:


Attachments
Patch (70.82 KB, patch)
2012-11-12 05:29 PST, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (73.40 KB, patch)
2012-11-12 18:32 PST, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (74.41 KB, patch)
2012-11-12 23:07 PST, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-11-07 23:45:46 PST
Add tests for week picker
Comment 1 Keishi Hattori 2012-11-12 05:29:40 PST
Created attachment 173632 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-12 09:11:49 PST
Comment on attachment 173632 [details]
Patch

Attachment 173632 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14804683

New failing tests:
platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html
platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html
platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html
Comment 3 Kent Tamura 2012-11-12 18:01:35 PST
Comment on attachment 173632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review

> LayoutTests/ChangeLog:11
> +        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.

nit: Don't you make the selection blue border rounded-corners?

> LayoutTests/ChangeLog:22
> +

Please update TextExpectations for pixel tests and the F4 difference of week-picker-key-operations.html.
Comment 4 Keishi Hattori 2012-11-12 18:07:36 PST
Comment on attachment 173632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review

>> LayoutTests/ChangeLog:11
>> +        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
> 
> nit: Don't you make the selection blue border rounded-corners?

This is intensional. If we round the corners the white background shows through at each corner.
Comment 5 Kent Tamura 2012-11-12 18:09:14 PST
Comment on attachment 173632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review

>>> LayoutTests/ChangeLog:11
>>> +        * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
>> 
>> nit: Don't you make the selection blue border rounded-corners?
> 
> This is intensional. If we round the corners the white background shows through at each corner.

ok, I understand.
Comment 6 Keishi Hattori 2012-11-12 18:32:02 PST
Created attachment 173786 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-12 22:36:39 PST
Comment on attachment 173786 [details]
Patch

Rejecting attachment 173786 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html
platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html
Full output: http://queues.webkit.org/results/14817497
Comment 8 Keishi Hattori 2012-11-12 23:07:00 PST
Created attachment 173829 [details]
Patch
Comment 9 Kent Tamura 2012-11-12 23:08:54 PST
Comment on attachment 173829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173829&action=review

> LayoutTests/platform/chromium/TestExpectations:4190
> +webkit.org/b/101561 platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ ImageOnlyFailure Pass ]
> +webkit.org/b/101561 platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ ImageOnlyFailure Pass ]
> +

CQ result was Missing.

Regressions: Unexpected missing results (2)
  platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ Missing ]
  platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ Missing ]
Comment 10 WebKit Review Bot 2012-11-13 00:04:08 PST
Comment on attachment 173829 [details]
Patch

Rejecting attachment 173829 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14822331
Comment 11 WebKit Review Bot 2012-11-13 02:52:54 PST
Comment on attachment 173829 [details]
Patch

Rejecting attachment 173829 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
yle/checkers/python.py", line 31, in <module>
    from webkitpy.thirdparty.autoinstalled.pylint import lint
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module>
    from pylint.checkers import utils
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module>
    from logilab.astng.utils import ASTWalker
ImportError: No module named logilab.astng.utils

Full output: http://queues.webkit.org/results/14809826
Comment 12 WebKit Review Bot 2012-11-14 19:53:26 PST
Comment on attachment 173829 [details]
Patch

Clearing flags on attachment: 173829

Committed r134731: <http://trac.webkit.org/changeset/134731>
Comment 13 WebKit Review Bot 2012-11-14 19:53:30 PST
All reviewed patches have been landed.  Closing bug.