Bug 101552 – Add properties for week/month picker in DateTimeChooserImpl::writeDocument

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Add properties for week/month picker in DateTimeChooserImpl::writeDocument

[Keishi Hattori]

Created attachment 172940 [details]
Patch

[Kent Tamura]

Comment on attachment 172940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172940&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        min/max for month picker should be months since epoch. todayLabel should be ThisWeek/ThisMonth for week/month pickers. And we need to add "mode" property.

How about "weekLabel"?

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:100
> +        minDate.setMillisecondsSinceEpochForDate(m_parameters.minimum);
> +        maxDate.setMillisecondsSinceEpochForDate(m_parameters.maximum);

Are you sure passing yyyy-mm-dd for mode:week?

[Keishi Hattori]

Created attachment 172991 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Kent Tamura]

Comment on attachment 172991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172991&action=review

> Source/Platform/chromium/public/WebLocalizedString.h:105
> +        WeekNumberLabel,
>          WeekFormatTemplate,

should keep alphabetical order

[Keishi Hattori]

Created attachment 173002 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173002 [details]
Patch

Clearing flags on attachment: 173002

Committed r133910: <http://trac.webkit.org/changeset/133910>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.