Bug 101546 - Remove unnecessary save/restore in SVGTextRunRenderingContext
Summary: Remove unnecessary save/restore in SVGTextRunRenderingContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 22:27 PST by Philip Rogers
Modified: 2012-11-08 07:20 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2012-11-07 22:33 PST, Philip Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2012-11-07 22:27:58 PST
The Skia team noticed SVG overzealously saves and restores contexts. SVGTextRunRenderingContext has a particularly egregious case where we save/restore on every text run just for stroke thickness:
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp?rev=133290#L145

Saves and restores are not free and we can pick up performance by avoiding them.
Comment 1 Philip Rogers 2012-11-07 22:33:52 PST
Created attachment 172934 [details]
Patch
Comment 2 Mike Reed 2012-11-08 05:02:41 PST
works for me
Comment 3 WebKit Review Bot 2012-11-08 07:20:26 PST
Comment on attachment 172934 [details]
Patch

Clearing flags on attachment: 172934

Committed r133897: <http://trac.webkit.org/changeset/133897>
Comment 4 WebKit Review Bot 2012-11-08 07:20:29 PST
All reviewed patches have been landed.  Closing bug.