Bug 101525 - [V8] Don't leak <img> elements in content scripts
Summary: [V8] Don't leak <img> elements in content scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 101110
  Show dependency tree / graph
 
Reported: 2012-11-07 17:21 PST by Adam Barth
Modified: 2012-11-07 23:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.71 KB, patch)
2012-11-07 17:23 PST, Adam Barth 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-11-07 17:21:11 PST 
[V8] Don't leak <img> elements in content scripts
Comment 1 Adam Barth 2012-11-07 17:23:17 PST 
Created attachment 172897 [details]
Patch
Comment 2 Ojan Vafai 2012-11-07 17:26:01 PST 
Comment on attachment 172897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172897&action=review

> Source/WebCore/bindings/v8/DOMDataStore.cpp:81
> +    ASSERT(object = static_cast<Node*>(toNative(wrapper)));

Nit: move this above line 79 since it doesn't actually use info?
Comment 3 Adam Barth 2012-11-07 17:27:44 PST 
Comment on attachment 172897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172897&action=review

>> Source/WebCore/bindings/v8/DOMDataStore.cpp:81
>> +    ASSERT(object = static_cast<Node*>(toNative(wrapper)));
> 
> Nit: move this above line 79 since it doesn't actually use info?

Will do.
Comment 4 Adam Barth 2012-11-07 17:30:05 PST 
Committed r133829: <http://trac.webkit.org/changeset/133829>
Comment 5 Kentaro Hara 2012-11-07 23:39:54 PST 
Comment on attachment 172897 [details]
Patch

LGTM too.