Bug 101519 – [V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API

[Adam Barth]

Created attachment 172887 [details]
Patch

[Adam Barth]

@ojan: Would you be willing to rs=you this patch so that the gardener can land it whenever the V8 patch lands?  (I haven't marked it for review because it won't compile without this API being present in V8.)

See http://code.google.com/p/chromium/issues/detail?id=159674 for more context.

[Ojan Vafai]

Comment on attachment 172887 [details]
Patch

Yes. RS=me

[Adam Barth]

Thanks.

[Adam Barth]

Committed r133945: <http://trac.webkit.org/changeset/133945>

[WebKit Review Bot]

Re-opened since this is blocked by bug 101645

[Adam Barth]

Committed r134323: <http://trac.webkit.org/changeset/134323>

[Ojan Vafai]

Looks like this was a large perf improvement across a large swath of DOM creation and traversal benchmarks. Well worth all the effort it took.

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dom_perf/report.html?rev=167377&graph=DOMWalk&history=150

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcoretraverse/report.html?rev=167377&graph=dom_traverse_lastChild&history=150

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcoretraverse/report.html?graph=dom_traverse&history=150&rev=167377

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dom_perf/report.html?graph=Get%20Elements&history=150&rev=167377

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dom_perf/report.html?graph=Get%20Elements&history=150&rev=167377

http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dom_perf/report.html?graph=Total&history=150&rev=167377

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcoremodify/report.html?graph=dom_modify_createElement&history=150&rev=167377

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dom_perf/report.html?graph=CreateNodes&history=150&rev=167377

http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dom_perf/report.html?graph=DOMDivWalk&history=150&rev=167377