Bug 101514 - Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
Summary: Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 14:57 PST by Simon Fraser (smfr)
Modified: 2012-11-10 21:21 PST (History)
7 users (show)

See Also:

Attachments
Patch (9.99 KB, patch)
2012-11-07 15:22 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-11-07 14:57:24 PST 
Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
Comment 1 Simon Fraser (smfr) 2012-11-07 15:22:13 PST 
Created attachment 172879 [details]
Patch
Comment 2 Tim Horton 2012-11-07 15:24:55 PST 
Comment on attachment 172879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172879&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:219
> +void ScrollingCoordinator::updateMainFrameScrollPosition(const IntPoint& scrollPosition, bool programmaticScroll, bool setLayerPosition)

More boolean arguments? :(

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:266
> +        scrollingTree()->updateMainFrameScrollPosition(scrollPosition, true /* setLayerPosition */);

See, this is the path down which those lead :)
Comment 3 Tim Horton 2012-11-07 16:10:57 PST 
Comment on attachment 172879 [details]
Patch

Fix the bools and all will be well?
Comment 4 Simon Fraser (smfr) 2012-11-10 21:21:59 PST 
http://trac.webkit.org/changeset/134169