RESOLVED FIXED 101513
[chromium] correct coding oversight for clang 
https://bugs.webkit.org/show_bug.cgi?id=101513
Summary [chromium] correct coding oversight for clang
Robert Kroeger
Reported 2012-11-07 14:45:07 PST
https://bugs.webkit.org/show_bug.cgi?id=100675 introduced interfaces for implementing gesture animation curves in the Chromium embedder. Sadly (nigh stupidly), it featured an incorrect declaration that prevents compilation of embedder provided functionality with clang. The attached patch fixes it.
Attachments
Patch (1.32 KB, patch)
2012-11-07 14:56 PST, Robert Kroeger 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Kroeger
Comment 1 2012-11-07 14:56:01 PST
Created attachment 172877 [details] Patch
Robert Kroeger
Comment 2 2012-11-07 14:57:11 PST
Comment on attachment 172877 [details] Patch Could you review please?
WebKit Review Bot
Comment 3 2012-11-07 14:59:25 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kent Tamura
Comment 4 2012-11-08 02:37:03 PST
Comment on attachment 172877 [details] Patch ok
WebKit Review Bot
Comment 5 2012-11-08 03:40:11 PST
Comment on attachment 172877 [details] Patch Rejecting attachment 172877 [details] from commit-queue. New failing tests: fast/repaint/selection-after-delete.html Full output: http://queues.webkit.org/results/14755815
Robert Kroeger
Comment 6 2012-11-08 07:29:29 PST
Comment on attachment 172877 [details] Patch I am reasonably convinced that the layout test fail is flake.
WebKit Review Bot
Comment 7 2012-11-08 07:44:12 PST
Comment on attachment 172877 [details] Patch Clearing flags on attachment: 172877 Committed r133901: <http://trac.webkit.org/changeset/133901>
WebKit Review Bot
Comment 8 2012-11-08 07:44:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.