Bug 101513 - [chromium] correct coding oversight for clang
Summary: [chromium] correct coding oversight for clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 14:45 PST by Robert Kroeger
Modified: 2012-11-08 07:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2012-11-07 14:56 PST, Robert Kroeger
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-11-07 14:45:07 PST
https://bugs.webkit.org/show_bug.cgi?id=100675 introduced interfaces for implementing gesture animation curves in the Chromium embedder. Sadly (nigh stupidly), it featured an incorrect declaration that prevents compilation of embedder provided functionality with clang. The attached patch fixes it.
Comment 1 Robert Kroeger 2012-11-07 14:56:01 PST
Created attachment 172877 [details]
Patch
Comment 2 Robert Kroeger 2012-11-07 14:57:11 PST
Comment on attachment 172877 [details]
Patch

Could you review please?
Comment 3 WebKit Review Bot 2012-11-07 14:59:25 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Kent Tamura 2012-11-08 02:37:03 PST
Comment on attachment 172877 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-11-08 03:40:11 PST
Comment on attachment 172877 [details]
Patch

Rejecting attachment 172877 [details] from commit-queue.

New failing tests:
fast/repaint/selection-after-delete.html
Full output: http://queues.webkit.org/results/14755815
Comment 6 Robert Kroeger 2012-11-08 07:29:29 PST
Comment on attachment 172877 [details]
Patch

I am reasonably convinced that the layout test fail is flake.
Comment 7 WebKit Review Bot 2012-11-08 07:44:12 PST
Comment on attachment 172877 [details]
Patch

Clearing flags on attachment: 172877

Committed r133901: <http://trac.webkit.org/changeset/133901>
Comment 8 WebKit Review Bot 2012-11-08 07:44:16 PST
All reviewed patches have been landed.  Closing bug.