Bug 101511 - DFG constant folding and CFG simplification should be smart enough to know that if a logical op's operand is proven to have a non-masquerading structure then it always evaluates to true
Summary: DFG constant folding and CFG simplification should be smart enough to know th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 101839
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-07 14:25 PST by Filip Pizlo
Modified: 2012-11-10 15:34 PST (History)
8 users (show)

See Also:

Attachments
the patch (19.55 KB, patch)
2012-11-07 14:31 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
the patch (21.13 KB, patch)
2012-11-10 14:04 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (21.12 KB, patch)
2012-11-10 14:05 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-07 14:25:33 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-11-07 14:31:57 PST 
Created attachment 172873 [details]
the patch
Comment 2 Filip Pizlo 2012-11-08 16:16:35 PST 
Landed in http://trac.webkit.org/changeset/133971
Comment 3 WebKit Review Bot 2012-11-10 07:03:31 PST 
Re-opened since this is blocked by bug 101839
Comment 4 Filip Pizlo 2012-11-10 13:24:55 PST 
Wow, that was a silly mistake.  I need to exclude strings from the boolean optimizations, since a string can be false (!!"" == false).
Comment 5 Filip Pizlo 2012-11-10 14:04:34 PST 
Created attachment 173471 [details]
the patch
Comment 6 Filip Pizlo 2012-11-10 14:05:31 PST 
Created attachment 173473 [details]
the patch
Comment 7 Geoffrey Garen 2012-11-10 15:32:20 PST 
Comment on attachment 173473 [details]
the patch

r=me
Comment 8 Filip Pizlo 2012-11-10 15:34:31 PST 
Relanded in http://trac.webkit.org/changeset/134164