When tapping on a misspelled word, look at the rootEditableElement to verify if it is the element under focus.
Created attachment 172870 [details] Patch
Attachment 172870 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 172870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172870&action=review Some stuff to fix, have a look at the style problem too and that the patch applies generally (guess we need to watch the bots). > Source/WebKit/blackberry/WebKitSupport/FatFingers.h:170 > + WebCore::Node* parentNode; You only need this in the while loop. > Source/WebKit/blackberry/WebKitSupport/FatFingers.h:174 > + break; Can you use parentElement here as well? > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:713 > + Element* parentElement; You only need this in the while loop.
Created attachment 172886 [details] Patch
Attachment 172886 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 172886 [details] Patch LGTM.
Comment on attachment 172886 [details] Patch Clearing flags on attachment: 172886 Committed r133902: <http://trac.webkit.org/changeset/133902>
All reviewed patches have been landed. Closing bug.