Bug 101506 – [EFL] Remove non-variable options from the build system

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Laszlo Gombos]

Some cmake variables - that are only used in the EFL specific part of the build system - are constants. As an example the WTF_USE_ICU_UNICODE cmake variable is only used in the EFL build system and for EFL it is always set to 1. The EFL port does not allow WTF_USE_ICU_UNICODE to be anything other than 1 (otherwise the port would probably not even build).

I find it confusing to have variables for things that can not be changed. I think it make the build system code more readable if we remove these variables.

[Laszlo Gombos]

Created attachment 172890 [details]
patch

This patch is first step to allow us to share list of files to build with other ports/build system and it will also allow EFL to use files like TextAllInOne.cpp.

[Kenneth Rohde Christiansen]

Comment on attachment 172890 [details]
patch

Lets have rafael look before committing

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 172890 [details]
patch

The cleanup looks fine, but since you have removed the IF checks from WebCore/PlatformEfl.cmake you should merge the changes to WebCore_SOURCES & co. to the original call at the top of the file.

[Laszlo Gombos]

(In reply to comment #3)
> (From update of attachment 172890 [details])
> The cleanup looks fine, but since you have removed the IF checks from WebCore/PlatformEfl.cmake you should merge the changes to WebCore_SOURCES & co. to the original call at the top of the file.

I agree. I will do that in a follow-up patch (also sort them and maybe start using some of the AllInOne files where it make sense). Thanks for helping with the review.

[WebKit Review Bot]

Comment on attachment 172890 [details]
patch

Clearing flags on attachment: 172890

Committed r133891: <http://trac.webkit.org/changeset/133891>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.