Bug 101496 - [EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
Summary: [EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 11:38 PST by Chris Dumez
Modified: 2012-11-07 13:08 PST (History)
6 users (show)

See Also:

Attachments
Patch (8.61 KB, patch)
2012-11-07 11:49 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.66 KB, patch)
2012-11-07 12:12 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-11-07 11:38:41 PST 
We currently have a default implementation of setWindowFrame() / getWindowFrame() in PageUIClientEfl which interacts with the Ecore_Evas containing the view. This default implementation no longer works for MiniBrowser since we ported to Elementary and since the browser is using elm_win.

It is therefore needed to add smart functions to ewk_view API allowing the client to provide its own implementation.
Comment 1 Chris Dumez 2012-11-07 11:49:00 PST 
Created attachment 172852 [details]
Patch
Comment 2 Chris Dumez 2012-11-07 12:12:54 PST 
Created attachment 172857 [details]
Patch

Fixed EwkViewImpl method names.
Comment 3 WebKit Review Bot 2012-11-07 13:08:38 PST 
Comment on attachment 172857 [details]
Patch

Clearing flags on attachment: 172857

Committed r133798: <http://trac.webkit.org/changeset/133798>
Comment 4 WebKit Review Bot 2012-11-07 13:08:42 PST 
All reviewed patches have been landed.  Closing bug.