Bug 101482 – [EFL] Define WTF_PLATFORM_EFL in Platform.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Laszlo Gombos]

to be consistent with other ports.

[Laszlo Gombos]

Created attachment 172823 [details]
1st try

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 172823 [details]
1st try

Was anything broken with the current behavior? The FIXME before the sections you change in Platform.h suggests that this isn't really a nice place to add more definitions (and, for consistency, this should also be changed in OptionsWindows.cmake).

[Laszlo Gombos]

(In reply to comment #2)
> (From update of attachment 172823 [details])
> Was anything broken with the current behavior?

Nothing is broken with the current solution. As the ChangeLog mentions this change is primary to align the EFL port with other ports. Improve readability/hackability for people not working on the EFL port on a daily basis if you wish.

> The FIXME before the sections you change in Platform.h suggests that this isn't really a nice place to add more definitions 

My reading of the FIXME is different. To me it means that we should minimize the usage of PLATFORM(XX) and use instead USE(XX), OS(XX) and other macros. I think it is easier to act on the FIXME if these definitions are all in common C/C++ code and not in port/build system specific files.

> (and, for consistency, this should also be changed in OptionsWindows.cmake).

I agree, thanks for pointing this out. It is probably better to do it in another patch as it impacts another port and not EFL.

[WebKit Review Bot]

Comment on attachment 172823 [details]
1st try

Clearing flags on attachment: 172823

Committed r135612: <http://trac.webkit.org/changeset/135612>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.