When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests. A patch is coming.
Created attachment 172817 [details] Patch
Comment on attachment 172817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172817&action=review > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-49 > - ecoreEvas = ecore_evas_buffer_new(800, 600); It seems you are dropping this ecore_evas_buffer_new . Do you know why it was here?
(In reply to comment #2) > (From update of attachment 172817 [details]) Thank you for your comment :) > View in context: https://bugs.webkit.org/attachment.cgi?id=172817&action=review > > > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-49 > > - ecoreEvas = ecore_evas_buffer_new(800, 600); > > It seems you are dropping this ecore_evas_buffer_new . Do you know why it was here? ecore_evas_buffer_new is not used anywhere else, so I thought it will be ok to change it so that it is the same as everywhere else. I am building webkit with AC turned off, and will report the results of running the tests once I have that.
Comment on attachment 172817 [details] Patch Clearing flags on attachment: 172817 Committed r133795: <http://trac.webkit.org/changeset/133795>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 172817 [details] [details]) > Thank you for your comment :) > > View in context: https://bugs.webkit.org/attachment.cgi?id=172817&action=review > > > > > Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-49 > > > - ecoreEvas = ecore_evas_buffer_new(800, 600); > > > > It seems you are dropping this ecore_evas_buffer_new . Do you know why it was here? > > ecore_evas_buffer_new is not used anywhere else, so I thought it will be ok to change it so that it is the same as everywhere else. I am building webkit with AC turned off, and will report the results of running the tests once I have that. Sorry for the delay. It took 1 hour 36 minutes to compile :( All 50 tests are passing with my change and AC turned off, so I don't see an issue with the change. thanks.