RESOLVED FIXED 101475
[AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking in GraphicsSurface 
https://bugs.webkit.org/show_bug.cgi?id=101475
Summary [AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are lea...
Sudarsana Nagineni (babu)
Reported 2012-11-07 07:54:46 PST
Noticed the following two memory leaks in GraphicsSurface. 1) http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp#L175 > m_fbConfigs = glXChooseFBConfig(m_display, DefaultScreen(m_display), attributes, &numReturned); GLX frame buffer configurations returned by glXChooseFBConfig leaking. 2) http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp#L196 > XVisualInfo* visualInfo = glXGetVisualFromFBConfig(m_display, m_fbConfigs[0]); Data returned by glXGetVisualFromFBConfig also leaking here. We must free these values by using XFree() to avoid memory leaks.
Attachments
Patch (1.86 KB, patch)
2012-11-07 08:12 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-11-07 08:12:09 PST
Created attachment 172806 [details] Patch
WebKit Review Bot
Comment 2 2012-11-07 12:33:28 PST
Comment on attachment 172806 [details] Patch Clearing flags on attachment: 172806 Committed r133791: <http://trac.webkit.org/changeset/133791>
WebKit Review Bot
Comment 3 2012-11-07 12:33:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.