Bug 101474 - [V8] WebKit sends unnecessary low memory notification when running memory benchmarks
Summary: [V8] WebKit sends unnecessary low memory notification when running memory ben...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ulan Degenbaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 07:51 PST by Ulan Degenbaev
Modified: 2012-11-07 09:12 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2012-11-07 08:03 PST, Ulan Degenbaev 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2012-11-07 08:18 PST, Ulan Degenbaev 		no flags Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2012-11-07 08:21 PST, Ulan Degenbaev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ulan Degenbaev 2012-11-07 07:51:24 PST 
In the following benchmark, we get GC pause of about 15 seconds because of low memory notification that was sent from WebKit.

http://people.mozilla.org/~wmccloskey/incremental-blog/example-pause.html

In this case the low memory notification is unnecessary because all memory usage consists of V8 objects, not DOM objects. So in this case V8 can schedule GC itself more optimally.
Comment 1 Ulan Degenbaev 2012-11-07 08:03:43 PST 
Created attachment 172804 [details]
Patch
Comment 2 Ulan Degenbaev 2012-11-07 08:18:57 PST 
Created attachment 172808 [details]
Patch
Comment 3 Kentaro Hara 2012-11-07 08:20:38 PST 
Comment on attachment 172808 [details]
Patch

I discussed with ulan offline. LGTM.
Comment 4 Ulan Degenbaev 2012-11-07 08:21:51 PST 
Created attachment 172811 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-07 09:12:44 PST 
Comment on attachment 172811 [details]
Patch

Clearing flags on attachment: 172811

Committed r133765: <http://trac.webkit.org/changeset/133765>
Comment 6 WebKit Review Bot 2012-11-07 09:12:48 PST 
All reviewed patches have been landed.  Closing bug.