Bug 101465 – [Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditional platform

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

Unfortunately there isn't any useful log uploaded by the bot:
http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Test%29/builds/7303

[Gabor Ballabas]

Some debug info.

Program received signal SIGSEGV, Segmentation fault.
0x0009af70 in JSC::CodeBlock::CodeBlock (this=0x7b7bb0, ownerExecutable=0x42c7c900, unlinkedCodeBlock=0x42dbfd50, globalObject=0x42c9fa40, baseScopeDepth=0, sourceProvider=..., 
    sourceOffset=0, alternative=...) at /home/bgabor/WebKit/Source/JavaScriptCore/bytecode/CodeBlock.cpp:1829
1829                CRASH();
(gdb) 
Continuing.
[Thread 0x42850450 (LWP 3590) exited]
[Inferior 1 (process 3589) exited with code 013]
(gdb) l
1824            case op_get_by_id_custom_proto:
1825            case op_get_by_id_custom_chain:
1826            case op_get_by_id_generic:
1827            case op_get_array_length:
1828            case op_get_string_length:
1829                CRASH();
1830
1831            case op_init_global_const_nop: {
1832                ASSERT(codeType() == GlobalCode);
1833                Identifier ident = identifier(pc[i + 4].u.operand);

[Gabor Ballabas]

Fix is coming just checking with the whole javascriptcore test-suite.

[Gabor Ballabas]

Created attachment 172798 [details]
Fix

[Oliver Hunt]

Comment on attachment 172798 [details]
Fix

Gah! Damnit, thanks Gabor.

[WebKit Review Bot]

Comment on attachment 172798 [details]
Fix

Rejecting attachment 172798 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
mit-queue/Source/WebKit/chromium/third_party/skia/gyp --revision 6303 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
45>At revision 6303.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14755531

[Csaba Osztrogonác]

Comment on attachment 172798 [details]
Fix

Clearing flags on attachment: 172798

Committed r133781: <http://trac.webkit.org/changeset/133781>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.