Bug 101457 - Web Inspector: Migrate inspector IndexedDB support to frontend API.
Summary: Web Inspector: Migrate inspector IndexedDB support to frontend API.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 05:39 PST by Vsevolod Vlasov
Modified: 2012-11-07 23:33 PST (History)
10 users (show)

See Also:

Attachments
Patch (38.34 KB, patch)
2012-11-07 05:43 PST, Vsevolod Vlasov 		pfeldman: review+
vsevik: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-11-07 05:39:27 PST 
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-11-07 05:43:45 PST 
Created attachment 172774 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-11-07 05:52:07 PST 
Joshua, Alec could one of you please check sanity of this before I land?
Comment 3 Alec Flett 2012-11-07 10:21:40 PST 
Comment on attachment 172774 [details]
Patch

One totally minor issue...other than that this looks good.


View in context: https://bugs.webkit.org/attachment.cgi?id=172774&action=review

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:453
> +            idbCursor->close();

Can you avoid calling close() and just let the cursor go out of scope (close() is not a method in the spec, so JS just lets it get GC'ed - we'll probably be making it private soon)
Comment 4 Vsevolod Vlasov 2012-11-07 11:44:06 PST 
(In reply to comment #3)
> (From update of attachment 172774 [details])
> One totally minor issue...other than that this looks good.
> 
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=172774&action=review
> 
> > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:453
> > +            idbCursor->close();
> 
> Can you avoid calling close() and just let the cursor go out of scope (close() is not a method in the spec, so JS just lets it get GC'ed - we'll probably be making it private soon)

Sure, I actually forgot to remove it when debugging an issue of inspector blocking database.
It turned out that I just needed to call database.close() instead.
Comment 5 Vsevolod Vlasov 2012-11-07 23:33:05 PST 
Committed r133855: <http://trac.webkit.org/changeset/133855>