RESOLVED FIXED 101457
Web Inspector: Migrate inspector IndexedDB support to frontend API. 
https://bugs.webkit.org/show_bug.cgi?id=101457
Summary Web Inspector: Migrate inspector IndexedDB support to frontend API.
Vsevolod Vlasov
Reported 2012-11-07 05:39:27 PST
Patch to follow.
Attachments
Patch (38.34 KB, patch)
2012-11-07 05:43 PST, Vsevolod Vlasov 		pfeldman: review+
vsevik: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-11-07 05:43:45 PST
Created attachment 172774 [details] Patch
Vsevolod Vlasov
Comment 2 2012-11-07 05:52:07 PST
Joshua, Alec could one of you please check sanity of this before I land?
Alec Flett
Comment 3 2012-11-07 10:21:40 PST
Comment on attachment 172774 [details] Patch One totally minor issue...other than that this looks good. View in context: https://bugs.webkit.org/attachment.cgi?id=172774&action=review > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:453 > + idbCursor->close(); Can you avoid calling close() and just let the cursor go out of scope (close() is not a method in the spec, so JS just lets it get GC'ed - we'll probably be making it private soon)
Vsevolod Vlasov
Comment 4 2012-11-07 11:44:06 PST
(In reply to comment #3) > (From update of attachment 172774 [details]) > One totally minor issue...other than that this looks good. > > > View in context: https://bugs.webkit.org/attachment.cgi?id=172774&action=review > > > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:453 > > + idbCursor->close(); > > Can you avoid calling close() and just let the cursor go out of scope (close() is not a method in the spec, so JS just lets it get GC'ed - we'll probably be making it private soon) Sure, I actually forgot to remove it when debugging an issue of inspector blocking database. It turned out that I just needed to call database.close() instead.
Vsevolod Vlasov
Comment 5 2012-11-07 23:33:05 PST
Committed r133855: <http://trac.webkit.org/changeset/133855>
Note You need to log in before you can comment on or make changes to this bug.