Bug 101451 - Web Inspector: Console: "time" and "timeEnd" should have same number of required arguments
Summary: Web Inspector: Console: "time" and "timeEnd" should have same number of requi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 05:06 PST by eustas.bug
Modified: 2012-11-15 18:51 PST (History)
13 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2012-11-07 06:01 PST, eustas.bug
no flags Details | Formatted Diff | Diff
Patch (1.49 KB, patch)
2012-11-07 23:39 PST, eustas.bug
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-11-07 05:06:40 PST
Steps to reproduce the problem:
1) Evaluate in console "console.time();"
Result: no complaint.

2) Evaluate "console.timeEnd();"

Result: error message "TypeError: Not enough arguments"

Expected result: the input requirements should be symmetrical.

Original issue: http://code.google.com/p/chromium/issues/detail?id=159375
Comment 1 eustas.bug 2012-11-07 06:01:01 PST
Created attachment 172781 [details]
Patch
Comment 2 Yury Semikhatsky 2012-11-07 23:31:00 PST
Comment on attachment 172781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172781&action=review

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please provide change description.
Comment 3 eustas.bug 2012-11-07 23:37:45 PST
Comment on attachment 172781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172781&action=review

>> Source/WebCore/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Please provide change description.

Ooops =) Fixed.
Comment 4 eustas.bug 2012-11-07 23:39:05 PST
Created attachment 172938 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-08 00:42:22 PST
Comment on attachment 172938 [details]
Patch

Rejecting attachment 172938 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14748951
Comment 6 Andrey Kosyakov 2012-11-08 04:41:16 PST
Committed r133881: <http://trac.webkit.org/changeset/133881>