WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
101444
[EFL] Add EFL to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=101444
Summary
[EFL] Add EFL to garden-o-matic
Thiago Marcos P. Santos
Reported
2012-11-07 03:42:08 PST
See for example what was done for Qt on
bug 82719
.
Attachments
Patch
(2.51 KB, patch)
2012-11-07 06:03 PST
,
Thiago Marcos P. Santos
no flags
Details
Formatted Diff
Diff
Patch
(2.18 KB, patch)
2012-11-14 04:08 PST
,
Thiago Marcos P. Santos
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1
2012-11-07 03:45:30 PST
Adding
bug 101345
as dependency since I we should use the new bot name/configuration.
Kangil Han
Comment 2
2012-11-07 04:15:45 PST
Seems garden-o-matic enables getting data from buildbot as a json format. Would you kindly introduce garden-o-matic to EFL webkittens?
Thiago Marcos P. Santos
Comment 3
2012-11-07 06:03:06 PST
Created
attachment 172782
[details]
Patch
WebKit Review Bot
Comment 4
2012-11-07 07:06:16 PST
Comment on
attachment 172782
[details]
Patch Clearing flags on attachment: 172782 Committed
r133757
: <
http://trac.webkit.org/changeset/133757
>
WebKit Review Bot
Comment 5
2012-11-07 07:06:21 PST
All reviewed patches have been landed. Closing bug.
Dominik Röttsches (drott)
Comment 6
2012-11-14 02:01:15 PST
Please fix the failing python test:
http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/68/steps/webkitpy-test/logs/stdio
Running the tests ... [1221/1595] webkitpy.tool.commands.rebaseline_unittest.TestRebaselineTest.test_baseline_directory failed: Traceback (most recent call last): File "/home/buildslave-1/webkit-buildslave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 91, in test_baseline_directory self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl-wk1") File "/home/buildslave-1/webkit-buildslave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 94, in _baseline_directory port = self._tool.port_factory.get_from_builder_name(builder_name) File "/home/buildslave-1/webkit-buildslave/efl-linux-64-release-wk2/build/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 144, in get_from_builder_name assert port_name, "unrecognized builder name '%s'" % builder_name AssertionError: unrecognized builder name 'EFL Linux 64-bit Debug'
Dominik Röttsches (drott)
Comment 7
2012-11-14 02:01:36 PST
Causes python test failure.
Thiago Marcos P. Santos
Comment 8
2012-11-14 04:08:40 PST
Created
attachment 174125
[details]
Patch
Csaba Osztrogonác
Comment 9
2012-11-14 04:10:14 PST
Comment on
attachment 174125
[details]
Patch LGTM,r=me.
WebKit Review Bot
Comment 10
2012-11-14 04:39:42 PST
Comment on
attachment 174125
[details]
Patch Clearing flags on attachment: 174125 Committed
r134594
: <
http://trac.webkit.org/changeset/134594
>
WebKit Review Bot
Comment 11
2012-11-14 04:39:47 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug