Bug 101440 – [Chromium] Arabic digits should appear left-to-right

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kenichi Ishibashi]

Created attachment 172739 [details]
testcase

Original report: http://code.google.com/p/chromium/issues/detail?id=158969
Test case attached (from the original report).

Arabic-Indic digits (U+06f0-U+06f9) should appear in increasing order from left to right.
HarfBuzzShaper renders these digits right to left in increasing order.

[Kenichi Ishibashi]

Created attachment 172741 [details]
Patch

[Kenichi Ishibashi]

Hi Tony,

Could you take a look?

[Tony Chang]

Comment on attachment 172741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235
> +    // HarfBuzz when we are calculating widths (except for directionalOverride() is set).

"except when directionOverride() is set" reads better in English.

[Kenichi Ishibashi]

Created attachment 173155 [details]
Patch for landing

[Kenichi Ishibashi]

Comment on attachment 172741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review

Thank you for review!

>> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235
>> +    // HarfBuzz when we are calculating widths (except for directionalOverride() is set).
> 
> "except when directionOverride() is set" reads better in English.

Done.

[WebKit Review Bot]

Comment on attachment 173155 [details]
Patch for landing

Clearing flags on attachment: 173155

Committed r133983: <http://trac.webkit.org/changeset/133983>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Behdad Esfahbod]

Humm.  In general webkit must always pass direction down to HarfBuzz.  It would be wrong to rely on autodetection in HarfBuzz since Webkit would have its own idea of the run direction.