Bug 101435 - Seam occurred between pieces of ShadowBlur on floating point zoom
Summary: Seam occurred between pieces of ShadowBlur on floating point zoom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 00:33 PST by KyungTae Kim
Modified: 2012-11-07 19:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2012-11-07 01:26 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2012-11-07 17:52 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Patch (1.93 KB, patch)
2012-11-07 17:56 PST, KyungTae Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2012-11-07 00:33:18 PST 
Issue>
When paint Shadow that doesn't have blurred edge on floating point zoom,
pixel seem occurred between pieces of the ShadowBlur because of unaligned clip rect.

Solution>
Enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing) even if the unaligned clip rect occurred
Comment 1 KyungTae Kim 2012-11-07 01:26:54 PST 
Created attachment 172736 [details]
Patch
Comment 2 Simon Fraser (smfr) 2012-11-07 16:27:41 PST 
Comment on attachment 172736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172736&action=review

> Source/WebCore/ChangeLog:3
> +        Seem occurred between pieces of ShadowBlur on floating point zoom

Seam. We often refer to these as "pixel cracks".

> Source/WebCore/ChangeLog:9
> +        pixel seem occurred between pieces of the ShadowBlur because of unaligned clip rect.

seam
Comment 3 KyungTae Kim 2012-11-07 17:52:42 PST 
Created attachment 172903 [details]
Patch
Comment 4 Simon Fraser (smfr) 2012-11-07 17:54:27 PST 
Comment on attachment 172903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172903&action=review

> Source/WebCore/ChangeLog:9
> +        pixel seam(pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect.

space before (
Comment 5 KyungTae Kim 2012-11-07 17:56:20 PST 
Created attachment 172904 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-07 19:03:35 PST 
Comment on attachment 172904 [details]
Patch

Clearing flags on attachment: 172904

Committed r133836: <http://trac.webkit.org/changeset/133836>
Comment 7 WebKit Review Bot 2012-11-07 19:03:40 PST 
All reviewed patches have been landed.  Closing bug.