Bug 101408 – [Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Joshua Bell]

Test:

platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html

Flakiness dashboard:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-key-operations.html

Seems to fail on each platform bot around once a day - bad test?

Failure is:

-PASS testToday() || testToday() is true
+FAIL testToday() || testToday() should be true. Was false.

Code is:

    // Test twice in case midnight.
    shouldBeTrue('testToday() || testToday()');

That seems sketchy.

[Joshua Bell]

Marked flaky in http://trac.webkit.org/changeset/133691

[Keishi Hattori]

Created attachment 172778 [details]
Patch

[Kent Tamura]

Comment on attachment 172778 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 172778 [details]
Patch

Clearing flags on attachment: 172778

Committed r133831: <http://trac.webkit.org/changeset/133831>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Klein]

This test now always fails on Mac:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-key-operations.html

Moreover, the "mouse" operations test next to it is flaky:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-mouse-operations.html

[Kent Tamura]

Created attachment 183719 [details]
Fix calendar-picker-key-operations.html on Mac

[Kentaro Hara]

Comment on attachment 183719 [details]
Fix calendar-picker-key-operations.html on Mac

Looks OK

[Kent Tamura]

(In reply to comment #6)
> Moreover, the "mouse" operations test next to it is flaky:
> 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-mouse-operations.html

It looks unrelated to this bug.  I filed Bug 107423, and will update TestExpectations.

[WebKit Review Bot]

Comment on attachment 183719 [details]
Fix calendar-picker-key-operations.html on Mac

Rejecting attachment 183719 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html
Full output: http://queues.webkit.org/results/16011208

[Kent Tamura]

(In reply to comment #10)
> New failing tests:
> platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html
> Full output: http://queues.webkit.org/results/16011208

I found LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt contained a FAIL line.  This patch will fix it too.

> PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]"
> FAIL document.getElementById("mock-page-popup") should be null. Was [object HTMLIFrameElement].
> PASS document.getElementById("date").value is "1999-12-26"

[Kent Tamura]

Created attachment 184112 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 184112 [details]
Patch for landing

Clearing flags on attachment: 184112

Committed r140501: <http://trac.webkit.org/changeset/140501>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.