Bug 101406 – Add API for touchEventHandlerRegion to WebLayer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Add API for touchEventHandlerRegion to WebLayer

Created attachment 172669 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

jamesr@ can you take a look at this when you get a chance? Thanks!

[WebKit Review Bot]

Comment on attachment 172669 [details]
Patch

Attachment 172669 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14745487

[Peter Beverloo (cr-android ews)]

Comment on attachment 172669 [details]
Patch

Attachment 172669 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14745506

[James Robinson]

Comment on attachment 172669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172669&action=review

> Source/Platform/chromium/public/WebLayer.h:194
> +    virtual void setTouchEventHandlerRegion(const WebVector<WebRect>&) = 0;
> +    virtual WebVector<WebRect> touchEventHandlerRegion() const = 0;

I would recommend that you not make these pure virtual, even though it's not consistent with the rest of the file.  Having them be pure virtual is a pain when trying to land a two-side patch of this nature.

Can you put this a few lines up next to setNonFastScrollable..()? there's a section there that has to do with input (setHaveWheel..., setShouldScroll..., setNonFast...) and I think this goes well with those

[James Robinson]

Comment on attachment 172669 [details]
Patch

R=me with those minor issues fixed

Created attachment 172830 [details]
Patch

jamesr@ can you put this on the CQ if it looks good? Thanks a lot!

[WebKit Review Bot]

Comment on attachment 172830 [details]
Patch

Clearing flags on attachment: 172830

Committed r133787: <http://trac.webkit.org/changeset/133787>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.